From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH 1/2] drm/i915: Move default: to the end of the switch Date: Wed, 05 Jun 2013 14:28:50 +0300 Message-ID: <87y5aolrt9.fsf@intel.com> References: <1370430101-4764-1-git-send-email-damien.lespiau@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga03.intel.com (mga03.intel.com [143.182.124.21]) by gabe.freedesktop.org (Postfix) with ESMTP id D7602E5C34 for ; Wed, 5 Jun 2013 04:28:25 -0700 (PDT) In-Reply-To: <1370430101-4764-1-git-send-email-damien.lespiau@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Damien Lespiau , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, 05 Jun 2013, Damien Lespiau wrote: > As it's usual to do, don't leave it in the middle of valid cases. > > Signed-off-by: Damien Lespiau > --- > drivers/gpu/drm/i915/i915_irq.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c > index 63996aa..a8ef086 100644 > --- a/drivers/gpu/drm/i915/i915_irq.c > +++ b/drivers/gpu/drm/i915/i915_irq.c > @@ -1484,14 +1484,14 @@ static void i915_get_extra_instdone(struct drm_device *dev, > instdone[0] = I915_READ(INSTDONE_I965); > instdone[1] = I915_READ(INSTDONE1); > break; > - default: > - WARN_ONCE(1, "Unsupported platform\n"); This is a functional change because of the follow through here. The commit message should reflect this. BR, Jani. > case 7: > instdone[0] = I915_READ(GEN7_INSTDONE_1); > instdone[1] = I915_READ(GEN7_SC_INSTDONE); > instdone[2] = I915_READ(GEN7_SAMPLER_INSTDONE); > instdone[3] = I915_READ(GEN7_ROW_INSTDONE); > break; > + default: > + WARN_ONCE(1, "Unsupported platform\n"); > } > } > > -- > 1.8.1.4 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Jani Nikula, Intel Open Source Technology Center