All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Rast <trast@inf.ethz.ch>
To: Junio C Hamano <gitster@pobox.com>
Cc: <git@vger.kernel.org>, Jonathan Nieder <jrnieder@gmail.com>,
	Jeff King <peff@peff.net>
Subject: Re: What's cooking in git.git (Apr 2013, #10; Mon, 29)
Date: Sat, 4 May 2013 10:40:16 +0200	[thread overview]
Message-ID: <87y5bvyw7j.fsf@hexa.v.cablecom.net> (raw)
In-Reply-To: <7vppxdgife.fsf@alter.siamese.dyndns.org> (Junio C. Hamano's message of "Mon, 29 Apr 2013 14:01:41 -0700")

Junio C Hamano <gitster@pobox.com> writes:

> * jn/config-ignore-inaccessible (2013-04-15) 1 commit
>  - config: allow inaccessible configuration under $HOME
>
>  When $HOME is misconfigured to point at an unreadable directory, we
>  used to complain and die. This loosens the check.
>
>  I do not think we agreed that this is a good idea, though.

As a data point: yesterday on IRC, two users complained that they each
had this problem.

  http://colabti.org/irclogger/irclogger_log/git?date=2013-05-03#l3022
  http://colabti.org/irclogger/irclogger_log/git?date=2013-05-03#l3111

So for one thing, "ha ha we told you so" is not an extremely
satisfactory answer, especially since we only "told them so" with the
recent doc update.  Wouldn't a stern warning or even an early error be
better?  It could be tempered by checking that HOME agrees with what
getpwnam says should be the HOME of the existing user, and checking that
it is not readable, before warning; more experienced users like the
scenario you mention in

  http://thread.gmane.org/gmane.comp.version-control.git/220661/focus=220921

would make sure that at least one of those conditions is not true.

But for another, they both claim that it fails even with HOME unset(!)
and even with a completely empty environment.  I cannot reproduce this,
but there might be another issue lurking?

-- 
Thomas Rast
trast@{inf,student}.ethz.ch

  parent reply	other threads:[~2013-05-04  8:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-29 21:01 What's cooking in git.git (Apr 2013, #10; Mon, 29) Junio C Hamano
2013-05-01  1:48 ` Felipe Contreras
2013-05-04  8:40 ` Thomas Rast [this message]
2013-05-04 19:27   ` Junio C Hamano
2013-05-04 20:14   ` jn/config-ignore-inaccessible (Re: What's cooking in git.git (Apr 2013, #10; Mon, 29)) Jonathan Nieder
2013-05-05  3:55     ` Junio C Hamano
2013-05-07 18:41       ` Jeff King
2013-05-06  9:54     ` Thomas Rast

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y5bvyw7j.fsf@hexa.v.cablecom.net \
    --to=trast@inf.ethz.ch \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jrnieder@gmail.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.