From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Date: Fri, 3 May 2013 13:59:31 +0300 Subject: [ath9k-devel] [PATCH 1/2] ath10k: Move debug structures to debug.h In-Reply-To: <20866.6443.838239.166937@gargle.gargle.HOWL> (Sujith Manoharan's message of "Thu, 2 May 2013 13:13:39 +0530") References: <1367316767-29559-1-git-send-email-sujith@msujith.org> <87hailhnjt.fsf@kamboji.qca.qualcomm.com> <20866.4677.890037.52323@gargle.gargle.HOWL> <87ehdpg7e9.fsf@kamboji.qca.qualcomm.com> <20866.6443.838239.166937@gargle.gargle.HOWL> Message-ID: <87y5bwba7g.fsf@kamboji.qca.qualcomm.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ath9k-devel@lists.ath9k.org Sujith Manoharan writes: > Kalle Valo wrote: >> The idea is that everything within ar variable can be found from core.h. >> That way people don't need to track down where it's actually defined. > > That doesn't seem to be the way things are organized. "ar" contains instances of > HTT, HTC, WMI, BMI, HIF - which all have separate header files. Likewise, having > a self-contained debug header files makes things cleaner, IMO. That's what the original codebase had (separate structures for each module), but we started moving it to the direction of having complete struct ath10k in core.h. It's a lot easier to manage everything that way. -- Kalle Valo