All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: James Hogan <james.hogan@imgtec.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
	Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
	arjan@infradead.org, linux-kernel@vger.kernel.org,
	andy.shevchenko@gmail.com
Subject: Re: [PATCH v2] modpost: fix unwanted VMLINUX_SYMBOL_STR expansion
Date: Mon, 29 Apr 2013 11:40:19 +0930	[thread overview]
Message-ID: <87y5c2ccj8.fsf@rustcorp.com.au> (raw)
In-Reply-To: <5179089E.3010005@imgtec.com>

James Hogan <james.hogan@imgtec.com> writes:
> Commit a4b6a77b77ba4f526392612c2365797fab956014 ("module: fix symbol
> versioning with symbol prefixes") broke the MODVERSIONS loading of any
> module using memcmp (e.g. ipv6) on x86_32, as it's defined to
> __builtin_memcmp which is expanded by VMLINUX_SYMBOL_STR. Use
> __VMLINUX_SYMBOL_STR instead which doesn't expand the argument.
>
> Reported-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
> Reported-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: James Hogan <james.hogan@imgtec.com>
> Cc: Rusty Russell <rusty@rustcorp.com.au>
> Cc: H. Peter Anvin <hpa@zytor.com>
> Tested-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
> Tested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>
> I've corrected commit message tags for Rusty's convenience.
> Updated Reported-by to include Andy
> Taken the liberty of adding Tetsuo's Tested-by

Applied.

Thanks especially for chasing this: I was away for a few days last week.

Cheers,
Rusty.

  reply	other threads:[~2013-04-29  3:18 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAHp75VdDwh0wgCWrVDcPps1C2qfdDZra15y9BQvzfWHzSMqbWA@mail.gmail.com>
2013-04-12 15:08 ` memcmp in modules Andy Shevchenko
2013-04-22 14:26   ` Tetsuo Handa
2013-04-23 12:40     ` [PATCH] x86_32: Fix module version table mismatch Tetsuo Handa
2013-04-23 14:14       ` Andy Shevchenko
2013-04-23 15:17       ` H. Peter Anvin
2013-04-23 15:41         ` Andy Shevchenko
2013-04-23 22:07           ` H. Peter Anvin
2013-04-23 22:56       ` H. Peter Anvin
2013-04-24  0:52       ` H. Peter Anvin
2013-04-24  1:00         ` H. Peter Anvin
2013-04-24 10:13           ` James Hogan
2013-04-24 11:24             ` Andy Shevchenko
2013-04-24 12:28             ` Tetsuo Handa
2013-04-24 13:49             ` Andy Shevchenko
2013-04-24 17:48             ` H. Peter Anvin
2013-04-25 10:42               ` [PATCH v2] modpost: fix unwanted VMLINUX_SYMBOL_STR expansion James Hogan
2013-04-29  2:10                 ` Rusty Russell [this message]
2013-04-23 23:15     ` memcmp in modules H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y5c2ccj8.fsf@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=andy.shevchenko@gmail.com \
    --cc=arjan@infradead.org \
    --cc=hpa@zytor.com \
    --cc=james.hogan@imgtec.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=penguin-kernel@I-love.SAKURA.ne.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.