From: l.stelmach@samsung.com (Łukasz Stelmach)
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: Git List <git@vger.kernel.org>
Subject: Re: [PATCH] send-email: support NNTP
Date: Wed, 24 Apr 2013 09:30:16 +0200 [thread overview]
Message-ID: <87y5c875dj.fsf@samsung.com> (raw)
In-Reply-To: <CAPig+cT18z7Hs70XMF99ACOs5cy2S=FTapjQO=Mb+EMYc=6hJw@mail.gmail.com>
It was <2013-04-24 śro 09:19>, when Eric Sunshine wrote:
> On Tue, Apr 23, 2013 at 7:13 AM, Łukasz Stelmach <l.stelmach@samsung.com> wrote:
>> Enable sending patches to NNTP servers (Usenet, Gmane).
>> ---
>> diff --git a/git-send-email.perl b/git-send-email.perl
>> index bd13cc8..0356635 100755
>> --- a/git-send-email.perl
>> +++ b/git-send-email.perl
>> @@ -1174,6 +1249,18 @@ X-Mailer: git-send-email $gitversion
>>
>> if ($dry_run) {
>> # We don't want to send the email.
>> + } elsif ($email_protocol eq 'nntp') {
>> + if (!defined $nntp_server) {
>> + die "The requires NNTP server is not properly defined."
>
> s/requires/required/
Done. Waiting for more comments.
--
Łukasz Stelmach
Software wizzard
Samsung Poland R&D Center
Al. Armii Ludowej 26, 00-609 Warszawa
http://www.rd.samsung.pl
next prev parent reply other threads:[~2013-04-24 7:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-23 11:13 [PATCH] send-email: support NNTP Łukasz Stelmach
2013-04-23 15:02 ` Junio C Hamano
2013-04-24 7:31 ` Łukasz Stelmach
2013-04-24 16:17 ` Junio C Hamano
2013-04-25 6:56 ` Łukasz Stelmach
2013-04-25 16:54 ` Junio C Hamano
2013-04-25 17:35 ` Junio C Hamano
2013-04-24 7:19 ` Eric Sunshine
2013-04-24 7:30 ` Łukasz Stelmach [this message]
2013-04-24 7:38 ` Thomas Rast
2013-04-24 8:42 ` Łukasz Stelmach
2013-04-24 9:29 ` Thomas Rast
2013-04-24 22:41 ` Junio C Hamano
2013-04-25 7:02 ` Łukasz Stelmach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y5c875dj.fsf@samsung.com \
--to=l.stelmach@samsung.com \
--cc=git@vger.kernel.org \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.