From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43389) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UN11k-0008Ou-3w for qemu-devel@nongnu.org; Tue, 02 Apr 2013 09:13:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UN11i-0007UD-Q2 for qemu-devel@nongnu.org; Tue, 02 Apr 2013 09:13:28 -0400 Received: from e23smtp07.au.ibm.com ([202.81.31.140]:36650) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UN11i-0007Sv-8q for qemu-devel@nongnu.org; Tue, 02 Apr 2013 09:13:26 -0400 Received: from /spool/local by e23smtp07.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 2 Apr 2013 23:04:28 +1000 Received: from d23relay03.au.ibm.com (d23relay03.au.ibm.com [9.190.235.21]) by d23dlp02.au.ibm.com (Postfix) with ESMTP id 97CD22BB0023 for ; Wed, 3 Apr 2013 00:13:07 +1100 (EST) Received: from d23av03.au.ibm.com (d23av03.au.ibm.com [9.190.234.97]) by d23relay03.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r32DD2ou2949566 for ; Wed, 3 Apr 2013 00:13:02 +1100 Received: from d23av03.au.ibm.com (loopback [127.0.0.1]) by d23av03.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r32DD62B019343 for ; Wed, 3 Apr 2013 00:13:06 +1100 From: Anthony Liguori In-Reply-To: <1364547764-6627-1-git-send-email-fred.konrad@greensocs.com> References: <1364547764-6627-1-git-send-email-fred.konrad@greensocs.com> Date: Tue, 02 Apr 2013 08:13:00 -0500 Message-ID: <87y5d1dqjn.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH v4 0/7] virtio-serial refactoring. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: fred.konrad@greensocs.com, qemu-devel@nongnu.org Cc: cornelia.huck@de.ibm.com, peter.maydell@linaro.org, mark.burton@greensocs.com, Amit Shah fred.konrad@greensocs.com writes: > From: KONRAD Frederic > > This is the next part of virtio-refactoring. > > Basically it creates virtio-serial device which extends virtio-device. > Then a virtio-serial can be connected on a virtio-bus. > virtio-serial-pci, virtio-serial-s390 and virtio-serial-ccw are created too, > they extend respectively virtio-pci, virtio-s390-device, virtio-ccw-device and > have a virtio-serial. > > You can checkout my branch here: > > git://project.greensocs.com/qemu-virtio.git virtio-serial-v4 > > Note that it is nearly the same series as virtio-blk and virtio-scsi > refactoring. > > I made basic tests (with linux guests) on: > * qemu-system-i386 > > CHanges v3 -> v': > * Removed serial configuration field ommited in VirtioCCWDevice structure. > > Changes v2 -> v3: > * Added CCW device. > * Rebased. Would like to at least see an Acked-by from Amit here... Regards, Anthony Liguori > > Thanks, > > Fred > > KONRAD Frederic (7): > virtio-serial: add the virtio-serial device. > virtio-serial-pci: switch to the new API. > virtio-serial-s390: switch to the new API. > virtio-serial-ccw: switch to the new API. > virtio-serial: cleanup: init and exit functions. > virtio-serial: cleanup: use QOM casts. > virtio-serial: cleanup: remove qdev field. > > hw/s390x/s390-virtio-bus.c | 32 +++++---- > hw/s390x/s390-virtio-bus.h | 12 +++- > hw/s390x/virtio-ccw.c | 30 +++++---- > hw/s390x/virtio-ccw.h | 12 +++- > hw/virtio-pci.c | 130 ++++++++++++++++++------------------- > hw/virtio-pci.h | 14 +++- > hw/virtio-serial-bus.c | 157 +++++++++++++++++++++++++++------------------ > hw/virtio-serial.h | 13 +++- > 8 files changed, 240 insertions(+), 160 deletions(-) > > -- > 1.7.11.7