From: Rusty Russell <rusty@rustcorp.com.au>
To: Asias He <asias@redhat.com>
Cc: "Michael S . Tsirkin" <mst@redhat.com>,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH 1/6] virtio_host: host-side implementation of virtio rings.
Date: Wed, 23 Jan 2013 12:26:41 +1030 [thread overview]
Message-ID: <87y5fk3bmu.fsf@rustcorp.com.au> (raw)
In-Reply-To: <50FE49E2.8080703@redhat.com>
Asias He <asias@redhat.com> writes:
> On 01/17/2013 06:29 PM, Rusty Russell wrote:
>> Getting use of virtio rings correct is tricky, and a recent patch saw
>> an implementation of in-kernel rings (as separate from userspace).
>>
>> This patch attempts to abstract the business of dealing with the
>> virtio ring layout from the access (userspace or direct); to do this,
>> we use function pointers, which gcc inlines correctly.
>>
>> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
>> ---
>> drivers/Makefile | 2 +-
>> drivers/vhost/Kconfig | 8 +
>> drivers/vhost/Kconfig.tcm | 1 +
>> drivers/vhost/Makefile | 2 +
>> drivers/vhost/vringh.c | 818 ++++++++++++++++++++++++++++++++++++++++++
>> drivers/virtio/virtio_ring.c | 33 +-
>> include/linux/virtio_ring.h | 57 +++
>
>
> Why vringh_notify_enable_user() and vringh_notify_disable_user() are not
> declared in include/linux/virtio_ring.h? Missed that?
Yes, I did... I've fixed it in my vringh branch, where I'm doing
development from now on.
Thanks!
Rusty.
next prev parent reply other threads:[~2013-01-23 1:56 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-17 10:29 [PATCH 1/6] virtio_host: host-side implementation of virtio rings Rusty Russell
2013-01-17 10:29 ` [PATCH 2/6] tools/virtio: fix compile Rusty Russell
2013-01-17 10:29 ` [PATCH 3/6] tools/virtio: separate headers more Rusty Russell
2013-01-17 10:29 ` [PATCH 4/6] tools/virtio: add vring_test Rusty Russell
2013-01-22 8:25 ` Asias He
2013-01-22 23:03 ` Rusty Russell
2013-01-23 1:40 ` Asias He
2013-01-24 2:22 ` Rusty Russell
2013-01-17 10:29 ` [PATCH 5/6] vringh: separate callback for notification Rusty Russell
2013-01-17 10:29 ` [PATCH 6/6] tools/virtio: adapt for API changes Rusty Russell
2013-01-17 11:23 ` [PATCH 1/6] virtio_host: host-side implementation of virtio rings Michael S. Tsirkin
2013-01-17 11:49 ` Sjur Brændeland
2013-01-17 12:08 ` Michael S. Tsirkin
2013-01-21 2:36 ` Rusty Russell
2013-01-22 14:54 ` Sjur Brændeland
2013-01-21 2:34 ` Rusty Russell
2013-01-21 9:41 ` Michael S. Tsirkin
2013-01-21 11:52 ` Rusty Russell
2013-01-21 12:24 ` Michael S. Tsirkin
2013-01-21 12:40 ` Michael S. Tsirkin
2013-01-21 22:57 ` Rusty Russell
2013-01-22 6:57 ` Rusty Russell
2013-01-22 7:13 ` Rusty Russell
2013-01-22 8:12 ` Asias He
2013-01-23 1:56 ` Rusty Russell [this message]
2013-02-04 20:29 ` Sjur Brændeland
2013-02-04 21:44 ` Rusty Russell
2013-02-12 18:58 ` Sjur Brændeland
2013-02-13 10:25 ` Rusty Russell
2013-02-14 14:54 ` Sjur Brændeland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y5fk3bmu.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=asias@redhat.com \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.