From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35748) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJn4I-0004VC-IB for qemu-devel@nongnu.org; Thu, 04 Oct 2012 11:10:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TJn4C-0007oU-B9 for qemu-devel@nongnu.org; Thu, 04 Oct 2012 11:10:30 -0400 Received: from mail-oa0-f45.google.com ([209.85.219.45]:61861) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJn4C-0007ms-6h for qemu-devel@nongnu.org; Thu, 04 Oct 2012 11:10:24 -0400 Received: by mail-oa0-f45.google.com with SMTP id i18so540719oag.4 for ; Thu, 04 Oct 2012 08:10:20 -0700 (PDT) From: Anthony Liguori In-Reply-To: <20121004144359.GA15784@otherpad.lan.raisama.net> References: <1349270954-4657-1-git-send-email-ehabkost@redhat.com> <1349270954-4657-2-git-send-email-ehabkost@redhat.com> <877gr6jqnt.fsf@codemonkey.ws> <506D940D.7080600@redhat.com> <87fw5uxqf6.fsf@codemonkey.ws> <20121004144359.GA15784@otherpad.lan.raisama.net> Date: Thu, 04 Oct 2012 10:10:16 -0500 Message-ID: <87y5jmz31j.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [RFC 01/18] pc: create "PC" device class List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: Paolo Bonzini , Gleb Natapov , qemu-devel@nongnu.org, Andreas =?utf-8?Q?F=C3=A4rber?= , Igor Mammedov Eduardo Habkost writes: > On Thu, Oct 04, 2012 at 09:28:13AM -0500, Anthony Liguori wrote: >> Paolo Bonzini writes: >> >> > Il 04/10/2012 15:46, Anthony Liguori ha scritto: >> >>> > +typedef struct PC { >> >>> > + DeviceState parent_obj; >> >>> > +} PC; >> >> So the general problem with this approach is that it strays from >> >> modeling hardware. >> > >> > It doesn't really; it's a motherboard object, there's no reason why >> > /machine shouldn't be a Device itself, with a few objects (CPUs, the >> > i440FX, the IOAPIC, and of course the peripherals) hanging off it. >> >> Okay, but modeling a motherboard is different than creating a "PC" >> object and throwing in the kitchen skink. >> >> And I'm not sure that going top-down is the best strategy. I think >> going bottom up makes more sense (starting with modeling Super IO chip). >> > > So, would you be OK with this implementation if the class were named > "Motherboard", "set-of-CPU-sockets", or something like that? I would, but you're mixing up modeling with bug fixing. There's a very easy way to achieve your goal without dramatic remodeling. Just assign APIC ids during CPU creation and make contiguous_apic_ids a parameter of pc_init1. You don't need to worry about CPU hotplug. It doesn't exist in qemu.git and is broken in qemu-kvm.git. Regards, Anthony Liguori > > (The change on the APIC ID generation logic is not something that > affects only individual CPUs or APICs, but the fw_cfg NUMA & CPU hotplug > code as well, that's why I don't think "contiguous_apic_ids" should be a > property of CPU or APIC objects). > > >> Regards, >> >> Anthony Liguori >> >> > >> > Paolo > > -- > Eduardo