All of lore.kernel.org
 help / color / mirror / Atom feed
From: ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org (Eric W. Biederman)
To: Zhao Hongjiang <zhaohongjiang37-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
Subject: Re: [PATCH] user_ns: compile bug fix in quota.h
Date: Thu, 06 Sep 2012 19:00:21 -0700	[thread overview]
Message-ID: <87y5kmlhhm.fsf@xmission.com> (raw)
In-Reply-To: <504848EC.3010904-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> (Zhao Hongjiang's message of "Thu, 06 Sep 2012 14:55:40 +0800")

Zhao Hongjiang <zhaohongjiang37-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> writes:

> From: Zhao Hongjiang <zhaohongjiang-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
>
> Failed to build userns-always-map-user-v53 from Eric's latest
> user_ns branch with GCC 4.4.4 compiler due to violation of
> C89 standard.

Thanks.

Given that they are C99 style initializers in general I don't see how
taking one member out of the initializer and leaving the other solves
the C89 violation.  But I do remember that gcc has historically had some
interesting problems with C99 initializers, so in this case I have just
opted to not use an initializer for either field, which should
make older gcc versions.

Eric

      parent reply	other threads:[~2012-09-07  2:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-06  6:55 [PATCH] user_ns: compile bug fix in quota.h Zhao Hongjiang
     [not found] ` <504848EC.3010904-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-09-07  2:00   ` Eric W. Biederman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y5kmlhhm.fsf@xmission.com \
    --to=ebiederm-as9lmozglivwk0htik3j/w@public.gmane.org \
    --cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=zhaohongjiang37-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.