From mboxrd@z Thu Jan 1 00:00:00 1970 From: OGAWA Hirofumi Subject: Re: [PATCH v2 4/4] fat: switch to fsinfo_inode Date: Sat, 14 Apr 2012 22:12:39 +0900 Message-ID: <87y5pyfoe0.fsf@devron.myhome.or.jp> References: <1334326795-2446-1-git-send-email-dedekind1@gmail.com> <1334326795-2446-5-git-send-email-dedekind1@gmail.com> <87fwc6hazv.fsf@devron.myhome.or.jp> <1334399379.2263.8.camel@koala> <87bomuha77.fsf@devron.myhome.or.jp> <1334401307.2263.24.camel@koala> <873986h6qa.fsf@devron.myhome.or.jp> <1334406974.2263.38.camel@koala> Mime-Version: 1.0 Content-Type: text/plain Cc: Andrew Morton , Linux Kernel Maling List , Linux FS Maling List , Artem Bityutskiy To: dedekind1@gmail.com Return-path: Received: from mail.parknet.co.jp ([210.171.160.6]:49081 "EHLO mail.parknet.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751144Ab2DNNMo (ORCPT ); Sat, 14 Apr 2012 09:12:44 -0400 In-Reply-To: <1334406974.2263.38.camel@koala> (Artem Bityutskiy's message of "Sat, 14 Apr 2012 15:36:11 +0300") Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Artem Bityutskiy writes: > On Sat, 2012-04-14 at 20:51 +0900, OGAWA Hirofumi wrote: >> Yes, I still worry about order. About ->sync_fs(), you are looking the >> following? > > Hirofumi, you still did not explain why the order matters. If it > matters, it should be easy to explain. > > But I will look at this and think about the ordering, thanks for > feed-back. But if you could explain why writing out FSINFO before inodes > is an issue, it'd be very helpful. Hm, you want to this one? If fsinfo is inode, the order can be 1) flush inodes 1a) flush fsinfo inode 1b) flush normal inodes 2) last iput(normal inodes) truncate() dirty fsinfo inode -- OGAWA Hirofumi