From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:57715) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RHGpj-0000il-8t for qemu-devel@nongnu.org; Fri, 21 Oct 2011 11:16:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RHGpe-0008ET-CP for qemu-devel@nongnu.org; Fri, 21 Oct 2011 11:16:31 -0400 Received: from e5.ny.us.ibm.com ([32.97.182.145]:43186) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RHGpe-00083x-90 for qemu-devel@nongnu.org; Fri, 21 Oct 2011 11:16:26 -0400 Received: from /spool/local by e5.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 21 Oct 2011 11:12:49 -0400 Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216]) by d01relay03.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p9LFBa54268076 for ; Fri, 21 Oct 2011 11:11:39 -0400 Received: from d01av02.pok.ibm.com (loopback [127.0.0.1]) by d01av02.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p9LFBW1e027072 for ; Fri, 21 Oct 2011 13:11:32 -0200 From: "Aneesh Kumar K.V" In-Reply-To: <201110202320.54504.jcmvbkbc@gmail.com> References: <201110202320.54504.jcmvbkbc@gmail.com> Date: Fri, 21 Oct 2011 20:40:46 +0530 Message-ID: <87y5we4byh.fsf@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] build with trace enabled is broken by the commit c572f23a3e7180dbeab5e86583e43ea2afed6271 hw/9pfs: Introduce tracing for 9p pdu handlers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Filippov , Harsh Prateek Bora Cc: qemu-devel@nongnu.org On Thu, 20 Oct 2011 23:20:54 +0400, Max Filippov wrote: > Hi. >=20 > Current git head build with trace enabled is broken by the commit c572f23= a3e7180dbeab5e86583e43ea2afed6271 hw/9pfs: Introduce tracing for 9p pdu han= dlers. > Error messages: >=20 > In file included from trace.c:2:0: > trace.h: In function =E2=80=98trace_v9fs_attach=E2=80=99: > trace.h:2850:9: error: too many arguments for format [-Werror=3Dformat-ex= tra-args] > trace.h: In function =E2=80=98trace_v9fs_wstat=E2=80=99: > trace.h:3039:9: error: too many arguments for format [-Werror=3Dformat-ex= tra-args] > trace.h: In function =E2=80=98trace_v9fs_mkdir=E2=80=99: > trace.h:3088:9: error: too many arguments for format [-Werror=3Dformat-ex= tra-args] > trace.h: In function =E2=80=98trace_v9fs_mkdir_return=E2=80=99: > trace.h:3095:9: error: too many arguments for format [-Werror=3Dformat-ex= tra-args] > cc1: all warnings being treated as errors >=20 > Prototypes in the trace-events do not match format strings, e.g. >=20 > v9fs_attach(uint16_t tag, uint8_t id, int32_t fid, int32_t afid, char* un= ame, char* aname) "tag %d id %d fid %d afid %d aname %s" >=20 > The following patch fixes it, but I'm not sure the format lines are appro= priate. Can you send the patch with signed-off-by: I will add it in the next pull request. -aneesh