From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH v3] ARM: OMAP3: PM: fix I/O wakeup and I/O chain clock control detection Date: Fri, 07 Oct 2011 13:40:26 -0700 Message-ID: <87y5wwk01x.fsf@ti.com> References: <20111006222912.GA27281@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: (Paul Walmsley's message of "Thu, 6 Oct 2011 17:18:45 -0600 (MDT)") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Paul Walmsley Cc: Steve Sakoman , dhylands@gmail.com, linux-omap@vger.kernel.org, Russell King - ARM Linux , linux-arm-kernel@lists.infradead.org List-Id: linux-omap@vger.kernel.org Paul Walmsley writes: > The way that we detect which OMAP3 chips support I/O wakeup and > software I/O chain clock control is broken. > > Currently, I/O wakeup is marked as present for all OMAP3 SoCs other > than the AM3505/3517. The TI81xx family of SoCs are at present > considered to be OMAP3 SoCs, but don't support I/O wakeup. To resolve > this, convert the existing blacklist approach to an explicit, > whitelist support, in which only SoCs which are known to support I/O > wakeup are listed. (At present, this only includes OMAP34xx, > OMAP3503, OMAP3515, OMAP3525, OMAP3530, and OMAP36xx.) > > Also, the current code incorrectly detects the presence of a > software-controllable I/O chain clock on several chips that don't > support it. This results in writes to reserved bitfields, unnecessary > delays, and console messages on kernels running on those chips: > > http://www.spinics.net/lists/linux-omap/msg58735.html > > Convert this test to a feature test with a chip-by-chip whitelist. > > Thanks to Dave Hylands for reporting this problem > and doing some testing to help isolate the cause. Thanks to Steve > Sakoman for catching a bug in the first version of > this patch. Thanks to Russell King for > comments. > > Signed-off-by: Paul Walmsley > Cc: Kevin Hilman > Cc: Dave Hylands > Cc: Steve Sakoman > Tested-by: Steve Sakoman > Cc: Russell King - ARM Linux > --- > > This version incorporates some comments from RMK - an unnecessary > set of parentheses are removed and a two-part error message string is > joined. Also, the printk(KERN_ERR has been converted into a pr_err(. OK, looks like we made some parallel changes. Dropping my version and will queue this one (branch: for_3.2/pm-cleanup-2) Kevin From mboxrd@z Thu Jan 1 00:00:00 1970 From: khilman@ti.com (Kevin Hilman) Date: Fri, 07 Oct 2011 13:40:26 -0700 Subject: [PATCH v3] ARM: OMAP3: PM: fix I/O wakeup and I/O chain clock control detection In-Reply-To: (Paul Walmsley's message of "Thu, 6 Oct 2011 17:18:45 -0600 (MDT)") References: <20111006222912.GA27281@n2100.arm.linux.org.uk> Message-ID: <87y5wwk01x.fsf@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Paul Walmsley writes: > The way that we detect which OMAP3 chips support I/O wakeup and > software I/O chain clock control is broken. > > Currently, I/O wakeup is marked as present for all OMAP3 SoCs other > than the AM3505/3517. The TI81xx family of SoCs are at present > considered to be OMAP3 SoCs, but don't support I/O wakeup. To resolve > this, convert the existing blacklist approach to an explicit, > whitelist support, in which only SoCs which are known to support I/O > wakeup are listed. (At present, this only includes OMAP34xx, > OMAP3503, OMAP3515, OMAP3525, OMAP3530, and OMAP36xx.) > > Also, the current code incorrectly detects the presence of a > software-controllable I/O chain clock on several chips that don't > support it. This results in writes to reserved bitfields, unnecessary > delays, and console messages on kernels running on those chips: > > http://www.spinics.net/lists/linux-omap/msg58735.html > > Convert this test to a feature test with a chip-by-chip whitelist. > > Thanks to Dave Hylands for reporting this problem > and doing some testing to help isolate the cause. Thanks to Steve > Sakoman for catching a bug in the first version of > this patch. Thanks to Russell King for > comments. > > Signed-off-by: Paul Walmsley > Cc: Kevin Hilman > Cc: Dave Hylands > Cc: Steve Sakoman > Tested-by: Steve Sakoman > Cc: Russell King - ARM Linux > --- > > This version incorporates some comments from RMK - an unnecessary > set of parentheses are removed and a two-part error message string is > joined. Also, the printk(KERN_ERR has been converted into a pr_err(. OK, looks like we made some parallel changes. Dropping my version and will queue this one (branch: for_3.2/pm-cleanup-2) Kevin