All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@deeprootsystems.com>
To: Ambresh K <ambresh@ti.com>
Cc: linux-omap@vger.kernel.org, Thara Gopinath <thara@ti.com>
Subject: Re: [PATCH] OMAP3: CLK: FIX: warning SR fclk clk domain not found
Date: Mon, 26 Apr 2010 11:25:17 -0700	[thread overview]
Message-ID: <87y6gat6k2.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1272001288-6981-1-git-send-email-ambresh@ti.com> (Ambresh K.'s message of "Fri\, 23 Apr 2010 11\:11\:28 +0530")

Ambresh K <ambresh@ti.com> writes:

> Added clock domain name to sr[1,2] clk structure to fix warning
> while initialising sr hwmod during boot-up.
>
> Signed-off-by: Ambresh K <ambresh@ti.com>

Please add a better subject and changelog.  Something that would be
more useful when looking at this in git history down the road.
Something like "add SR clocks to WKUP clockdomain" for the suject is
more helpful.

Also, for the changelog, explain more about SmartReflex having its own
powerdomain but no clockdomain, thus why it's clocks are in the WKUP
clockdomain.

Kevin


> ---
>  arch/arm/mach-omap2/clock3xxx_data.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/clock3xxx_data.c b/arch/arm/mach-omap2/clock3xxx_data.c
> index d5153b6..8a49d8a 100644
> --- a/arch/arm/mach-omap2/clock3xxx_data.c
> +++ b/arch/arm/mach-omap2/clock3xxx_data.c
> @@ -3100,6 +3100,7 @@ static struct clk sr1_fck = {
>  	.parent		= &sys_ck,
>  	.enable_reg	= OMAP_CM_REGADDR(WKUP_MOD, CM_FCLKEN),
>  	.enable_bit	= OMAP3430_EN_SR1_SHIFT,
> +	.clkdm_name	= "wkup_clkdm",
>  	.recalc		= &followparent_recalc,
>  };
>  
> @@ -3110,6 +3111,7 @@ static struct clk sr2_fck = {
>  	.parent		= &sys_ck,
>  	.enable_reg	= OMAP_CM_REGADDR(WKUP_MOD, CM_FCLKEN),
>  	.enable_bit	= OMAP3430_EN_SR2_SHIFT,
> +	.clkdm_name	= "wkup_clkdm",
>  	.recalc		= &followparent_recalc,
>  };
>  
> -- 
> 1.6.0.4

      reply	other threads:[~2010-04-26 18:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-23  5:41 [PATCH] OMAP3: CLK: FIX: warning SR fclk clk domain not found Ambresh K
2010-04-26 18:25 ` Kevin Hilman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y6gat6k2.fsf@deeprootsystems.com \
    --to=khilman@deeprootsystems.com \
    --cc=ambresh@ti.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=thara@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.