From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NeVbf-0006Ny-U2 for qemu-devel@nongnu.org; Mon, 08 Feb 2010 10:32:59 -0500 Received: from [199.232.76.173] (port=32834 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NeVbf-0006Nm-Fo for qemu-devel@nongnu.org; Mon, 08 Feb 2010 10:32:59 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NeVbe-0006Mf-8N for qemu-devel@nongnu.org; Mon, 08 Feb 2010 10:32:59 -0500 Received: from mx.meyering.net ([82.230.74.64]:58387) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NeVbd-0006MH-TN for qemu-devel@nongnu.org; Mon, 08 Feb 2010 10:32:58 -0500 From: Jim Meyering In-Reply-To: <4B702B60.4000904@redhat.com> (Kevin Wolf's message of "Mon, 08 Feb 2010 16:18:56 +0100") References: <87hbprsrei.fsf@meyering.net> <4B702B60.4000904@redhat.com> Date: Mon, 08 Feb 2010 16:32:57 +0100 Message-ID: <87y6j3rbdi.fsf@meyering.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: [Qemu-devel] Re: [PATCH] qcow2: don't ignore failed update_refcount List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org Kevin Wolf wrote: ... > I'm currently working on fixing exactly this, and unfortunaly, no, it's > not that easy. What you introduce looks like proper error handling at > first sight, but what happens in fact is that while the current write > request correctly fails now we're running with corrupted metadata for > all future requests (the new refcount table/block is already in use, but > it has a refcount of 0 and will be overwritten sooner or later). > > Actually, I have found it impossible to fix the current approach, so the > fix I'm working on will be more of a rewrite of the two functions. Nicely worded NACK ;-) Thanks.