From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andi Kleen <andi@firstfloor.org>
Subject: Re: [PATCH] tweak memory error correction field in the
	SMBIOS data
Date: Wed, 25 Nov 2009 11:27:28 +0100
Message-ID: <87y6luvqzz.fsf@basil.nowhere.org>
References: <1259086479-12444-1-git-send-email-pbonzini@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <1259086479-12444-1-git-send-email-pbonzini@redhat.com> (Paolo
	Bonzini's message of "Tue, 24 Nov 2009 19:14:39 +0100")
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

Paolo Bonzini <pbonzini@redhat.com> writes:

> Microsoft's Windows logo certified hardware requires single- or
> multi-bit ECC; since the SVVP certification runs the same test
> on the guest, Xen domains will currently fail it.
>
> -    p->error_correction = 0x01; /* other */
> +    p->error_correction = 0x06; /* Multi-bit ECC to make Microsoft happy */


That's lying if the host doesn't support ECC.

It would be better if you checked that on the host and then
set it appropiately in the guest too.

-Andi
-- 
ak@linux.intel.com -- Speaking for myself only.