From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH 2/6] Fix pci_add storage not to exit on bad first argument
Date: Fri, 25 Sep 2009 18:36:25 +0200 [thread overview]
Message-ID: <87y6o3ouba.fsf@pike.pond.sub.org> (raw)
In-Reply-To: <1f7e6a1805b4e87537d2626cd338981247fce316.1253843232.git.armbru@redhat.com> (Markus Armbruster's message of "Fri\, 25 Sep 2009 03\:53\:49 +0200")
Markus Armbruster <armbru@redhat.com> writes:
> Monitor command "pci_add ADDR storage ..." does its work in
> qemu_pci_hot_add_nic(). It called pci_create(..., ADDR) to create the
Oops, make that qmu_pci_hot_add_storage().
> device. That's wrong, because pci_create() terminates the program
> when ADDR is invalid.
>
> Use pci_get_bus_devfn() and pci_create_noinit() instead.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
next prev parent reply other threads:[~2009-09-25 16:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-25 1:53 [Qemu-devel] [PATCH 0/6] Fix pci_add not to exit on error & other fixes Markus Armbruster
2009-09-25 1:53 ` [Qemu-devel] [PATCH 1/6] Fix pci_vga_init() not to ignore bus argument Markus Armbruster
2009-09-25 1:53 ` [Qemu-devel] [PATCH 2/6] Fix pci_add storage not to exit on bad first argument Markus Armbruster
2009-09-25 16:36 ` Markus Armbruster [this message]
2009-09-25 1:53 ` [Qemu-devel] [PATCH 3/6] Make it obvious that pci_nic_init() can't fail Markus Armbruster
2009-09-25 1:53 ` [Qemu-devel] [PATCH 4/6] Fix pci_add nic not to exit on bad model Markus Armbruster
2009-09-25 1:53 ` [Qemu-devel] [PATCH 5/6] pci_create() is now unused, remove it Markus Armbruster
2009-09-25 1:53 ` [Qemu-devel] [PATCH 6/6] Rename pci_create_noinit() to pci_create() Markus Armbruster
2009-09-25 10:44 ` [Qemu-devel] [PATCH 0/6] Fix pci_add not to exit on error & other fixes Gerd Hoffmann
2009-09-25 14:12 ` Markus Armbruster
2009-09-25 16:26 ` Luiz Capitulino
2009-09-28 16:05 ` Mark McLoughlin
2009-09-28 16:16 ` Mark McLoughlin
2009-09-28 19:14 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y6o3ouba.fsf@pike.pond.sub.org \
--to=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.