From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MrDmc-0005m8-1o for qemu-devel@nongnu.org; Fri, 25 Sep 2009 12:36:34 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MrDmX-0005gL-5F for qemu-devel@nongnu.org; Fri, 25 Sep 2009 12:36:33 -0400 Received: from [199.232.76.173] (port=42346 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MrDmW-0005g6-Nj for qemu-devel@nongnu.org; Fri, 25 Sep 2009 12:36:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:1845) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MrDmW-00072v-1E for qemu-devel@nongnu.org; Fri, 25 Sep 2009 12:36:28 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n8PGaRoi010916 for ; Fri, 25 Sep 2009 12:36:27 -0400 Received: from pike.pond.sub.org (vpn-10-124.str.redhat.com [10.32.10.124]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id n8PGaQnK027686 for ; Fri, 25 Sep 2009 12:36:26 -0400 References: <1f7e6a1805b4e87537d2626cd338981247fce316.1253843232.git.armbru@redhat.com> From: Markus Armbruster Date: Fri, 25 Sep 2009 18:36:25 +0200 In-Reply-To: <1f7e6a1805b4e87537d2626cd338981247fce316.1253843232.git.armbru@redhat.com> (Markus Armbruster's message of "Fri\, 25 Sep 2009 03\:53\:49 +0200") Message-ID: <87y6o3ouba.fsf@pike.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: [Qemu-devel] Re: [PATCH 2/6] Fix pci_add storage not to exit on bad first argument List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Markus Armbruster writes: > Monitor command "pci_add ADDR storage ..." does its work in > qemu_pci_hot_add_nic(). It called pci_create(..., ADDR) to create the Oops, make that qmu_pci_hot_add_storage(). > device. That's wrong, because pci_create() terminates the program > when ADDR is invalid. > > Use pci_get_bus_devfn() and pci_create_noinit() instead. > > Signed-off-by: Markus Armbruster