All of lore.kernel.org
 help / color / mirror / Atom feed
From: Teemu Likonen <tlikonen@iki.fi>
To: Sverre Rabbelier <srabbelier@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
	"Shawn O. Pearce" <spearce@spearce.org>,
	Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	Git List <git@vger.kernel.org>
Subject: Re: [PATCH v5a 1/6] fast-import: put option parsing code in seperate functions
Date: Thu, 27 Aug 2009 21:52:42 +0300	[thread overview]
Message-ID: <87y6p5xf5x.fsf@iki.fi> (raw)
In-Reply-To: <1251398431-12461-2-git-send-email-srabbelier@gmail.com> (Sverre Rabbelier's message of "Thu, 27 Aug 2009 11:40:26 -0700")

On 2009-08-27 11:40 (-0700), Sverre Rabbelier wrote:

> Putting the options in their own functions increases readability of
> the option parsing block and makes it easier to reuse the option
> parsing code later on.
>
> Signed-off-by: Sverre Rabbelier <srabbelier@gmail.com>

Typo in the title:

    fast-import: put option parsing code in seperate functions
                                               ^

"separate"

  parent reply	other threads:[~2009-08-27 18:52 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-27 18:40 [PATCH v5a 0/6] add new feature and option command Sverre Rabbelier
2009-08-27 18:40 ` [PATCH v5a 1/6] fast-import: put option parsing code in seperate functions Sverre Rabbelier
2009-08-27 18:40   ` [PATCH v5a 2/6] fast-import: put marks reading in it's own function Sverre Rabbelier
2009-08-27 18:40     ` [RFC PATCH v5a 3/6] fast-import: add feature command Sverre Rabbelier
2009-08-27 18:40       ` [RFC PATCH v5a 4/6] fast-import: test the new " Sverre Rabbelier
2009-08-27 18:40         ` [PATCH v5a 5/6] fast-import: add option command Sverre Rabbelier
2009-08-27 18:40           ` [PATCH v5a 6/6] fast-import: test the new " Sverre Rabbelier
2009-08-27 18:52   ` Teemu Likonen [this message]
2009-08-27 19:37     ` [PATCH v5a 1/6] fast-import: put option parsing code in seperate functions Sverre Rabbelier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y6p5xf5x.fsf@iki.fi \
    --to=tlikonen@iki.fi \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=spearce@spearce.org \
    --cc=srabbelier@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.