From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH 4/4] ALSA: ASoC: Davinci: Fixed missing McBSP pinmux for SFFSDR Date: Tue, 10 Mar 2009 10:11:22 -0700 Message-ID: <87y6vds3ph.fsf@deeprootsystems.com> References: <1236655929-31688-1-git-send-email-hugo@hugovil.com> <1236655929-31688-5-git-send-email-hugo@hugovil.com> <20090310102921.GA12297@sirena.org.uk> <20090310100341.cc08cc08.hugo@hugovil.com> <20090310151615.GB12297@sirena.org.uk> <20090310114211.4ad49269.hugo@hugovil.com> <87hc21tlt1.fsf@deeprootsystems.com> <20090310120434.0e6db8e7.hugo@hugovil.com> <874oy1tkn4.fsf@deeprootsystems.com> <20090310130734.c877b1f6.hugo@hugovil.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from rv-out-0506.google.com (rv-out-0506.google.com [209.85.198.232]) by alsa0.perex.cz (Postfix) with ESMTP id BB4761037F1 for ; Tue, 10 Mar 2009 18:11:26 +0100 (CET) Received: by rv-out-0506.google.com with SMTP id f9so2305531rvb.0 for ; Tue, 10 Mar 2009 10:11:25 -0700 (PDT) In-Reply-To: <20090310130734.c877b1f6.hugo@hugovil.com> (Hugo Villeneuve's message of "Tue\, 10 Mar 2009 13\:07\:34 -0400") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Hugo Villeneuve Cc: davinci-linux-open-source@linux.davincidsp.com, alsa-devel@alsa-project.org, Mark Brown List-Id: alsa-devel@alsa-project.org Hugo Villeneuve writes: > On Tue, 10 Mar 2009 09:20:15 -0700 > Kevin Hilman wrote: > >> Hugo Villeneuve writes: >> >> > On Tue, 10 Mar 2009 08:55:06 -0700 >> > Kevin Hilman wrote: >> > >> >> Hugo Villeneuve writes: >> >> >> >> > On Tue, 10 Mar 2009 15:16:32 +0000 >> >> > Mark Brown wrote: >> >> > >> >> >> On Tue, Mar 10, 2009 at 10:03:41AM -0400, Hugo Villeneuve wrote: >> >> >> >> >> >> > I based those patches on the latest linux-davinci git tree, >> >> >> > which has the function. >> >> >> >> >> >> Do not submit patches for mainline which are not based on >> >> >> mainline trees. Code which relies on out of tree changes needs >> >> >> to wait for those out of tree changes to be merged before >> >> >> submitting to mainline. >> >> > >> >> > I did not know that these changes were not in mainline yet. I was >> >> > told that all davinci ASoC code changes were to be submitted only >> >> > to ALSA, and then were imported back into the davinci git tree. >> >> > Apparently this is not quite like that anymore. >> >> > >> >> > Kevin, what is the new rule to submit davinci ASoC patches? >> >> > >> >> >> >> The DaVinci ASoC code is indeed in mainline, but not all of the >> >> DaVinci core (in this case the pin mux) is yet in mainline. I >> >> will be pushing it during the next merge window. >> > >> > That doesn't really answer my question. >> > >> > I can see that David Brownell pushed a patch to the davinci tree >> > directly modifying sound/soc/davinci/davinci-evm.c which IS in >> > mainline. Does this means that as of now all ASoC patches should be >> > sent first to the Davinci list, and then you will push those to the >> > mainline kernel? >> > >> >> No ASoc patches should be generated against an ASoC tree and submitted >> to alsa-devel, and CC davinci list. >> >> This means that the until the DaVinci core is in mainline, DaVinci >> git will have slightly different looking ASoC drivers, but those >> changes will be minimal. > > Ok, so the patch affecting sound/soc/davinci/davinci-evm.c SHOULD have > been submitted to ALSA first. Yes, but it should've been a patch against an ASoC tree, not against DaVinci git which may contain things not (yet) in the ASoC tree. > It is not easy following you guys. You say something and then do the > opposite. Heh, sorry. Do as I do, not as I say. ;) Kevin