From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Korsgaard Subject: Re: [patch 2.6.27-rc6] spi_mpc83xx: reject invalid transfer sizes Date: Thu, 11 Sep 2008 09:17:57 +0200 Message-ID: <87y71zb17e.fsf@macbook.be.48ers.dk> References: <200809101713.21496.david-b@pacbell.net> <20080910190030.5ef3c1fd.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: David Brownell , spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Joakim Tjernlund To: Andrew Morton Return-path: In-Reply-To: <20080910190030.5ef3c1fd.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org> (Andrew Morton's message of "Wed\, 10 Sep 2008 19\:00\:30 -0700") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org >>>>> "Andrew" == Andrew Morton writes: Andrew> Why? What user-visible problem (if any) does this fix? I slightly reworded the commit text in the update I sent last night (no code changes), but David apparently missed it: [PATCH] spi_mpc83xx: handle odd transfer sizes Error out on transfer length != multiple of bytes per word with -EINVAL. Fixes a buffer overrun crash if length < bytes per word. I hope this is clearer - You can update the text in the patch if you like. Andrew> I have not been provided with sufficient information to be Andrew> able to decide whether this fix is needed in 2.6.27. Please Andrew> always provide this. Sorry, It's 2.6.27 material because of the crash. -- Bye, Peter Korsgaard ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/