From: Andi Kleen <andi@firstfloor.org>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>,
Linux and Kernel Video <video4linux-list@redhat.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: v4l & compat_ioctl
Date: 28 Mar 2008 12:25:31 +0100 [thread overview]
Message-ID: <87y783jdjo.fsf@basil.nowhere.org> (raw)
In-Reply-To: <47ECD0CF.1020003@gmail.com>
Jiri Slaby <jirislaby@gmail.com> writes:
> wouldn't make sense to add v4l ioctls to ioctl_start
> (fs/compat_ioctl.c) table to allow i386 stuff such as skype to run
> video on x86_64?
Don't make it a question.
In general any ioctl in any driver runnable on any 64bit
architecture that has a 32bit compat layer should have compat
support. Not having it is a bug.
However the new standard way to do this is to not
add new stuff into compat_ioctl.c, but define ->compat_ioctl
entry points in the low level drivers (and ideally converted
them to ->unlocked_ioctl too while you're at it)
-Andi
next prev parent reply other threads:[~2008-03-28 11:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-28 11:04 v4l & compat_ioctl Jiri Slaby
2008-03-28 11:25 ` Andi Kleen [this message]
2008-03-28 11:31 ` Jiri Slaby
2008-03-28 11:38 ` Andi Kleen
2008-03-28 12:22 ` Jiri Slaby
2008-03-28 13:35 ` Andi Kleen
2008-03-28 17:24 ` Mauro Carvalho Chehab
2008-03-28 17:24 ` Mauro Carvalho Chehab
2008-03-28 17:26 ` Jiri Slaby
2008-03-28 17:47 ` Mauro Carvalho Chehab
2008-03-28 17:47 ` Mauro Carvalho Chehab
2008-03-28 18:07 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y783jdjo.fsf@basil.nowhere.org \
--to=andi@firstfloor.org \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=video4linux-list@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.