From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JM8K9-0004bg-PA for mharc-grub-devel@gnu.org; Mon, 04 Feb 2008 15:53:53 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JM8K8-0004Zm-Gd for grub-devel@gnu.org; Mon, 04 Feb 2008 15:53:52 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JM8K4-0004Ue-ME for grub-devel@gnu.org; Mon, 04 Feb 2008 15:53:50 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JM8K3-0004U2-Sr for grub-devel@gnu.org; Mon, 04 Feb 2008 15:53:47 -0500 Received: from smtp-vbr15.xs4all.nl ([194.109.24.35]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JM8K2-0001cb-T6 for grub-devel@gnu.org; Mon, 04 Feb 2008 15:53:47 -0500 Received: from localhost.localdomain (249-174.surfsnel.dsl.internl.net [145.99.174.249]) by smtp-vbr15.xs4all.nl (8.13.8/8.13.8) with ESMTP id m14KrfwU067648 for ; Mon, 4 Feb 2008 21:53:41 +0100 (CET) (envelope-from mgerards@xs4all.nl) From: Marco Gerards To: The development of GRUB 2 References: <1202074413.560.7.camel@k9.localnet> <874pco90mm.fsf@xs4all.nl> <1202156471.582.11.camel@k9.localnet> Mail-Copies-To: mgerards@xs4all.nl Date: Mon, 04 Feb 2008 21:55:30 +0100 In-Reply-To: <1202156471.582.11.camel@k9.localnet> (wa1ter@myrealbox.com's message of "Mon, 04 Feb 2008 12:21:11 -0800") Message-ID: <87y7a05tml.fsf@xs4all.nl> User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by XS4ALL Virus Scanner X-detected-kernel: by monty-python.gnu.org: FreeBSD 4.6-4.9 Subject: Re: [PATCH] to make grub2 compile on NetBSD X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Feb 2008 20:53:53 -0000 walt writes: > On Mon, 2008-02-04 at 16:56 +0100, Marco Gerards wrote: >> walt writes: >> >> > NetBSD's gcc wants libgcc and libc to define __enable_execute_stack, >> > but this is useless for a free-standing executable like grub. Define >> > a dummy function in lieu of libgcc to supply __enable_execute_stack. > >> ... If this is for NetBSD only, >> shouldn't you add a #ifdef instead of a comment? > > Second try: > > Make NetBSD's gcc happy. > > * kern/mm.c: New dummy symbol __enable_execute_stack. > (include/grub/mm.h): Likewise. The patch looks fine to me. Can you please supply the header for the changelog entry? It's not complete this way. -- Marco