From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1HxID2-00038n-90 for mharc-grub-devel@gnu.org; Sun, 10 Jun 2007 03:51:36 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HxICz-00038g-PC for grub-devel@gnu.org; Sun, 10 Jun 2007 03:51:33 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HxICx-00038A-B5 for grub-devel@gnu.org; Sun, 10 Jun 2007 03:51:32 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HxICx-000387-4w for grub-devel@gnu.org; Sun, 10 Jun 2007 03:51:31 -0400 Received: from smtp-vbr9.xs4all.nl ([194.109.24.29]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1HxICx-0006Sp-00 for grub-devel@gnu.org; Sun, 10 Jun 2007 03:51:31 -0400 Received: from localhost.localdomain (249-174.surfsnel.dsl.internl.net [145.99.174.249]) by smtp-vbr9.xs4all.nl (8.13.8/8.13.8) with ESMTP id l5A7pSwu014732 for ; Sun, 10 Jun 2007 09:51:29 +0200 (CEST) (envelope-from mgerards@xs4all.nl) From: Marco Gerards To: The development of GRUB 2 References: <20070609045616.GA9839@ws3.vdp.com> <87645x2ebq.fsf@xs4all.nl> <20070610034253.GA617@ws3.vdp.com> Mail-Copies-To: mgerards@xs4all.nl Date: Sun, 10 Jun 2007 09:57:44 +0200 In-Reply-To: <20070610034253.GA617@ws3.vdp.com> (bean123@126.com's message of "Sun, 10 Jun 2007 11:42:53 +0800") Message-ID: <87y7is1bt3.fsf@xs4all.nl> User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by XS4ALL Virus Scanner X-detected-kernel: FreeBSD 4.6-4.9 Subject: Re: Update for NTFS file system driver X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 10 Jun 2007 07:51:33 -0000 Bean writes: > On Sat, Jun 09, 2007 at 08:05:45PM +0200, Marco Gerards wrote: >> >> The normal procedure for patches is to make them consistent with the >> GCS (GNU Coding Standards), include a changelog. That way it is >> easier to review the patch and to include it in GRUB 2. > > Can you give me an example ? Here is an example of a patch I sent in recently: http://lists.gnu.org/archive/html/grub-devel/2007-05/msg00114.html The GNU Coding Standards: http://www.gnu.org/prep/standards/standards.html The specific part on ChangeLog entries: http://www.gnu.org/prep/standards/standards.html#Change-Logs The biggest part is on indentation, etc. -- Marco