From: Sergei Organov <osv@javad.com>
To: Denis Vlasenko <vda@ilport.com.ua>
Cc: Alan Cox <alan@redhat.com>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
rmk+serial@arm.linux.org.uk
Subject: Re: [PATCH] moxa: do not ignore input
Date: Tue, 20 Jun 2006 21:17:44 +0400 [thread overview]
Message-ID: <87y7vrpwzr.fsf@javad.com> (raw)
In-Reply-To: <200506031601.21180.vda@ilport.com.ua> (Denis Vlasenko's message of "Fri, 3 Jun 2005 16:01:21 +0300")
Denis Vlasenko <vda@ilport.com.ua> writes:
> Stop using tty internal structure in mxser_receive_chars(),
> use tty_insert_flip_char(tty, ch flag); istead.
>
> Without this change driver ignores any rx'ed chars.
>
> Run tested, please apply.
>
> Any suggestions on further cleanups this driver may need
> while I have access to this hardware?
I have 8-port board, but mxser creates 16 devices anyway, and forces any
application accessing one of those inexistent devices to segfault, e.g.:
osv@osv ~$ cat /dev/ttyM9
Segmentation fault
osv@osv ~$
This is on 2.6.14 kernel though, -- didn't try with more recent kernels
as I have other troubles with them on my hardware/distribution.
Not a big deal, but you've asked yourself ;)
--
Sergei.
next prev parent reply other threads:[~2006-06-20 17:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-02 9:20 Moxa multi serial driver doesn't pass received chars up Denis Vlasenko
2005-06-02 12:54 ` Denis Vlasenko
2005-06-02 22:58 ` Alan Cox
2005-06-03 13:01 ` [PATCH] moxa: do not ignore input Denis Vlasenko
2006-06-20 17:17 ` Sergei Organov [this message]
2006-06-21 11:51 ` Alan Cox
2006-06-21 11:41 ` Sergei Organov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y7vrpwzr.fsf@javad.com \
--to=osv@javad.com \
--cc=alan@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=rmk+serial@arm.linux.org.uk \
--cc=vda@ilport.com.ua \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.