From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Esk9B-0004dI-VH for mharc-grub-devel@gnu.org; Sat, 31 Dec 2005 12:04:02 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Esk91-0004a2-GM for grub-devel@gnu.org; Sat, 31 Dec 2005 12:03:51 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Esk8x-0004Ys-Ea for grub-devel@gnu.org; Sat, 31 Dec 2005 12:03:48 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Esk8v-0004Xz-2Y for grub-devel@gnu.org; Sat, 31 Dec 2005 12:03:45 -0500 Received: from [194.109.24.27] (helo=smtp-vbr7.xs4all.nl) by monty-python.gnu.org with esmtp (Exim 4.34) id 1Esk9d-0001tD-VX for grub-devel@gnu.org; Sat, 31 Dec 2005 12:04:30 -0500 Received: from localhost.localdomain (mgerards.xs4all.nl [82.92.27.129]) by smtp-vbr7.xs4all.nl (8.13.3/8.13.3) with ESMTP id jBVH2CBN011621 for ; Sat, 31 Dec 2005 18:02:12 +0100 (CET) (envelope-from mgerards@xs4all.nl) Mail-Copies-To: mgerards@xs4all.nl To: The development of GRUB 2 References: <43B1DD7E.5090905@omniflux.com> From: Marco Gerards Date: Sat, 31 Dec 2005 18:02:15 +0100 In-Reply-To: <43B1DD7E.5090905@omniflux.com> (omniflux+lists@omniflux.com's message of "Tue, 27 Dec 2005 17:34:06 -0700") Message-ID: <87y8219p48.fsf@xs4all.nl> User-Agent: Gnus/5.1007 (Gnus v5.10.7) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by XS4ALL Virus Scanner Subject: Re: [PATCH] User definable terminfo support X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 31 Dec 2005 17:03:54 -0000 Omniflux writes: Hi, Thanks a lot for your patch! > terminfo-definition-support.diff > * term/terminfo.c: Replaced static vt100 definition with user > definable definition support. > * include/grub/terminfo.h (grub_terminfo_get_current): Removed. > (grub_terminfo_set_current): Likewise Is it possible to do this in a GRUB env. variable, like: set TERM=vt100 And perhaps one variable or function to set the possible terminal descriptions. I think that would be easier for the user to do it this way. > As with the previous serial patch, some code here is based on the > terminfo support from GRUB Legacy. Any mistakes, however, are mine. :) > > I would appreciate comments and suggestions, especially for the short > parameter selection for the reverse video and cursor options. > > I tried not using a short parameter, but state[x].set does not get set > in that case, or I tried incorrectly. Sure, I'll look at this code after the weekend. The feedback I will give will be more useful than the feedback above... Can you provide a ChangeLog entry so the patch can be reviewed and applied? See the GNU Coding Standards (GCS) for information about how to write a changelog entry. If you have questions about this, feel free to contact me. > Also can someone point me to instructions for creating a menu so that > I may test other then the command line? At the moment I am working on the menu code, so the syntax will be changed really soon. But at the moment you can do something like: title foo linux /vmlinux ... title bar ... Thanks, Marco