From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1DsR6L-0003Ha-Vj for mharc-grub-devel@gnu.org; Tue, 12 Jul 2005 16:11:34 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DsR6L-0003HL-AS for grub-devel@gnu.org; Tue, 12 Jul 2005 16:11:33 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DsR6J-0003Gd-Ir for grub-devel@gnu.org; Tue, 12 Jul 2005 16:11:32 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DsR1u-0001Xw-8o for grub-devel@gnu.org; Tue, 12 Jul 2005 16:06:58 -0400 Received: from [145.74.66.11] (helo=mail-cn.han.nl) by monty-python.gnu.org with esmtp (Exim 4.34) id 1DsQje-0003QL-Hw for grub-devel@gnu.org; Tue, 12 Jul 2005 15:48:06 -0400 Received: from vscan-cn.han.nl (venus.han.nl [145.74.65.6]) by mail-cn.han.nl (Postfix) with ESMTP id E0F458BFE for ; Tue, 12 Jul 2005 21:40:10 +0200 (CEST) Received: from mail-cn.han.nl ([145.74.66.11]) by vscan-cn.han.nl (venus.han.nl [145.74.65.6]) (amavisd-new, port 10024) with ESMTP id 29484-08 for ; Tue, 12 Jul 2005 20:46:33 +0200 (CEST) Received: from mail1.han.nl (mail1.han.nl [145.74.103.11]) by mail-cn.han.nl (Postfix) with ESMTP id 02D718B54 for ; Tue, 12 Jul 2005 21:40:08 +0200 (CEST) Received: from localhost.localdomain (mgerards.xs4all.nl [82.92.27.129]) by mail1.han.nl (Postfix) with ESMTP id C2038C048 for ; Tue, 12 Jul 2005 21:40:07 +0200 (CEST) Mail-Copies-To: metgerards@student.han.nl To: The development of GRUB 2 References: <42D26452.3010706@yahoo.fr> <200507121258.40668.okuji@enbug.org> <42D3B827.4090103@yahoo.fr> <87hdf0p4jy.fsf@student.han.nl> <42D3C877.3040607@yahoo.fr> <5b8d0feefaf6717dc015cc834de2da1b@penguinppc.org> <877jfwowlo.fsf@student.han.nl> <42D41013.4040601@yahoo.fr> From: Marco Gerards Date: Tue, 12 Jul 2005 21:40:08 +0200 In-Reply-To: <42D41013.4040601@yahoo.fr> (Vincent Pelletier's message of "Tue, 12 Jul 2005 20:46:43 +0200") Message-ID: <87y88bolt3.fsf@student.han.nl> User-Agent: Gnus/5.1007 (Gnus v5.10.7) Emacs/21.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by amavisd-new (2.2.0) at vscan-cn.han.nl Subject: Re: sparc64 port : diffs to powerpc branches X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Jul 2005 20:11:33 -0000 Vincent Pelletier writes: Hi Vincent, > Here are the diffs powerpc -> usparc, with some comments below. > To be used to know which files can be made common. Nice! > All the ieee1275 functions use the grub_intn_t type (see includes). So this can be shared. > Add explicit casts where needed. > disk: > Special ppc test removed. This is an important test. Please do not remove it so this code can be shared. Just make sure GRUB_IEEE1275_FLAG_NO_PARTITION_0 is set or not set, depending on how OB works. > Types changed. > > include: > ieee1275 functions prototypes updated. > Add explicit casts where needed. > Special ppc structs removed. > multiboot.h, libgcc removed (weren't modified). > Types length modified. Can this be done in a way that we can share most (all?) headers related to ieee 1275? > kern: > New dummy function (no asm). > dl updated to 64 bits ELF, but I'm not sure where it is used... You have to write the relocator first. It is used for module loading. > Changed "abort" to use "enter" OF standard function : now it *does* > return when the user types "go" at the OF prompt. Perhaps we can do this on the PPC port as well? > Changed some suspicious "&string" to just "string". hm? > Added malloc calls when size can be known. Nice! > Removed "XXX" when documentation answers. Nice! > Disabled (#if 0) unused function. Can you write the code so it works on both the PPC and sparc so this code can be shared? Some code you disabled like this has a function on the PPC, IIRC. > Remove ppc specific partition numbering thing. Can you explain this? > normal: > New dummy function (no asm). When you implement this, you can support switching from normal to rescue mode and back properly. > term: > Type changes. > Added an environment variable to disable cls (useful to see early messages). Ok. > util: > Brute changes... Like dl, I don't know when it is used, so... grub-mkimage is used to add modules to grubof. Do you want me to fully review the complete patch or was it just a reference for your description? Thanks, Marco