All of lore.kernel.org
 help / color / mirror / Atom feed
From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Roland McGrath <roland@redhat.com>
Cc: Andrew Morton <akpm@osdl.org>, Linus Torvalds <torvalds@osdl.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] notify_parent and ptrace cleanup
Date: Thu, 26 Aug 2004 04:48:25 +0900	[thread overview]
Message-ID: <87y8k3knhy.fsf@devron.myhome.or.jp> (raw)
In-Reply-To: <200408251808.i7PI8jFF017075@magilla.sf.frob.com>

Roland McGrath <roland@redhat.com> writes:

> > ptrace() is frangible, and racy. And looks like few things can't improve
> > without user visible change. So, I'm thinking I would like to rewrite
> > it by another interface.
> 
> I don't think such vague statements are useful.  Are there other races you
> are implicitly referring to here, or only the ones I have just cited?
> These issues are with the implementation, not the interface.  Changing the
> ptrace interface won't do anything about them, and fixing them need not
> change the ptrace interface.
> 
> The ptrace interface could use replacing, but that is really a separate
> issue.  I will be first in line to replace it with something that has saner
> semantics and a more convenient user interface.  But that won't help a whit
> with things like these race concerns.  Let's keep the issue of an ugly
> interface separate from the issue of potential bugs in the one we have.  If
> there are bugs (aside from the inherent limitations of the intended
> semantics), they need to be fixed.

Sorry for about it. Yes, racy is implementation issue. And AFAIK, it
seems to be fixed by we don't allow SIGCONT. (If it doesn't break userland)

> > And looks like few things can't improve without user visible
> > change. So, I'm thinking I would like to rewrite it by another
> > interface.

This is reason that I wouldn't like that we continue to be expanding
ptrace().

Thanks.
-- 
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>

  reply	other threads:[~2004-08-25 19:51 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-18  0:40 [PATCH] notify_parent cleanup Roland McGrath
2004-08-18  6:44 ` Andrew Morton
2004-08-21  1:09   ` [PATCH] notify_parent and ptrace cleanup Roland McGrath
2004-08-21 11:47     ` OGAWA Hirofumi
2004-08-25  2:43       ` Roland McGrath
2004-08-25 17:51         ` OGAWA Hirofumi
2004-08-25 18:08           ` Roland McGrath
2004-08-25 19:48             ` OGAWA Hirofumi [this message]
2004-08-25 19:54               ` Linus Torvalds
2004-08-25 20:20                 ` Roland McGrath
2004-08-25 20:53                   ` OGAWA Hirofumi
2004-08-25 21:02                     ` Linus Torvalds
2004-08-25 21:07                       ` Roland McGrath
2004-08-25 21:45                         ` OGAWA Hirofumi
2004-08-19  4:26 ` [PATCH] notify_parent cleanup OGAWA Hirofumi
2004-08-19 20:59   ` Roland McGrath
2004-08-19 22:01     ` OGAWA Hirofumi
2004-08-19 22:04       ` Roland McGrath

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y8k3knhy.fsf@devron.myhome.or.jp \
    --to=hirofumi@mail.parknet.co.jp \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=roland@redhat.com \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.