From: Takashi Iwai <tiwai@suse.de>
To: raoxu <raoxu@uniontech.com>
Cc: perex@perex.cz, tiwai@suse.com, luiz.von.dentz@intel.com,
pmenzel@molgen.mpg.de, pengpeng@iscas.ac.cn, brgl@kernel.org,
u.kleine-koenig@baylibre.com, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ALSA: intel8x0: keep AC97 PCM descriptors for ICH4 capture
Date: Thu, 05 Nov 2026 08:50:59 +0100 [thread overview]
Message-ID: <87zevnsom4.wl-tiwai@suse.de> (raw)
In-Reply-To: <5387AE07DB9C7930+20261105014642.73877-1-raoxu@uniontech.com>
On Thu, 05 Nov 2026 02:46:42 +0100,
raoxu wrote:
>
> From: Xu Rao <raoxu@uniontech.com>
>
> When S/PDIF uses the AC-link, spdif_idx is negative and the AC97
> PCM assignment drops its last descriptor. On ICH4 this leaves five
> entries, but PCM2IN and MIC2 still use entries four and five.
> Opening MIC2 then reads beyond the allocated descriptor array.
>
> Keep all six descriptors on ICH4 so the capture stream indices stay
> valid. The S/PDIF descriptor occupies its fixed position but does
> not create a separate hardware PCM when S/PDIF uses the AC-link.
> Other controller types retain their existing descriptor counts.
>
> Signed-off-by: Xu Rao <raoxu@uniontech.com>
Applied now. Thanks.
Takashi
prev parent reply other threads:[~2026-11-05 7:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-05 1:46 [PATCH v2] ALSA: intel8x0: keep AC97 PCM descriptors for ICH4 capture raoxu
2026-11-05 7:50 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zevnsom4.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=brgl@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=luiz.von.dentz@intel.com \
--cc=pengpeng@iscas.ac.cn \
--cc=perex@perex.cz \
--cc=pmenzel@molgen.mpg.de \
--cc=raoxu@uniontech.com \
--cc=tiwai@suse.com \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.