From: Takashi Iwai <tiwai@suse.de>
To: Harin Lee <me@harin.net>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Dany Patoine <dany_patoine@hotmail.com>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
regressions@lists.linux.dev
Subject: Re: [PATCH] ALSA: ctxfi: Fix silent playback on Titanium HD (SB1270)
Date: Wed, 30 Sep 2026 14:29:43 +0200 [thread overview]
Message-ID: <87zewy53d4.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260930115824.739412-1-me@harin.net>
On Wed, 30 Sep 2026 13:58:24 +0200,
Harin Lee wrote:
>
> Commit 4b490e0d103c ("ALSA: ctxfi: Add ADC helper functions for GPIO")
> moved the GPIO_DATA read into hw_adc_stop(), but the Titanium HD
> (SB1270) setup in hw_adc_init() uses the local data variable holding
> the GPIO_CTRL value.
>
> Writing this value to GPIO_DATA sets the output mute bits. Playback
> runs without errors, but the outputs stay muted.
>
> Re-read GPIO_DATA before setting the speed mode bits. Also, add the
> delay after writing the mode bits, as in the original sequence.
>
> On affected kernels, switching the output selection was reported to
> restore clean playback.
>
> Fixes: 4b490e0d103c ("ALSA: ctxfi: Add ADC helper functions for GPIO")
> Cc: stable@vger.kernel.org
> Reported-by: Dany Patoine <dany_patoine@hotmail.com>
> Closes: https://lore.kernel.org/linux-sound/DM6PR02MB5433A42E81FEFAC400DD1905EA8B2@DM6PR02MB5433.namprd02.prod.outlook.com/
> Signed-off-by: Harin Lee <me@harin.net>
Applied now. Thanks.
Takashi
prev parent reply other threads:[~2026-09-30 12:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-30 11:58 [PATCH] ALSA: ctxfi: Fix silent playback on Titanium HD (SB1270) Harin Lee
2026-09-30 12:29 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zewy53d4.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=dany_patoine@hotmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=me@harin.net \
--cc=perex@perex.cz \
--cc=regressions@lists.linux.dev \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.