From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5C796CA5FAE for ; Tue, 29 Sep 2026 15:05:20 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xBZOI-0007z7-02; Tue, 29 Sep 2026 11:05:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xBZOC-0007uD-Mu for qemu-devel@nongnu.org; Tue, 29 Sep 2026 11:05:04 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xBZOA-0005Jm-QW for qemu-devel@nongnu.org; Tue, 29 Sep 2026 11:05:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1790694301; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bPF6YkrQQvXnH2v6hsG5flwcmdtTCGmrnJ437+DJ6EE=; b=AKZd03UK0F1pG9Ki5tMCe6NACO2JFpzY1crJtAQYqRZ7mVseoHEokl8Uv9l9diWOQg01Rm 9LnpwCuAOjOzDxasRLK6CvyvVJ+BFTp4PlYRNKUSoD51zPAnjU9vMpARptt4RqThkptmm1 1fFI4uil9rpKTad8JHfwc9cI8v559Ss= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-484-VHwlG_uBNm2MD1d-tC9KhA-1; Tue, 29 Sep 2026 11:04:56 -0400 X-MC-Unique: VHwlG_uBNm2MD1d-tC9KhA-1 X-Mimecast-MFC-AGG-ID: VHwlG_uBNm2MD1d-tC9KhA_1790694294 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 093DF195607C; Tue, 29 Sep 2026 15:04:54 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.44.22.5]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id CD5161956045; Tue, 29 Sep 2026 15:04:52 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 67DAD21E6A04; Tue, 29 Sep 2026 17:04:50 +0200 (CEST) From: Markus Armbruster To: John Snow Cc: Markus Armbruster , qemu-devel , Peter Xu , Daniel P. =?utf-8?Q?Berrang=C3=A9?= , Stefan Berger , Fabiano Rosas , Hanna Reitz , Paolo Bonzini , Zhao Liu , Kevin Wolf , Ani Sinha , Pierrick Bouvier , Jiri Pirko , Alex Williamson , Kashyap Chamarthy , Peter Maydell , Kostiantyn Kostiuk , Stefan Hajnoczi , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Michael Roth , Mauro Carvalho Chehab , Vladimir Sementsov-Ogievskiy , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Qemu-block , =?utf-8?Q?C=C3=A9dric?= Le Goater , Stefano Garzarella , Richard Henderson , "Michael S. Tsirkin" , Igor Mammedov , Jason Wang , Alex =?utf-8?Q?Benn=C3=A9e?= , Eric Blake Subject: Re: [PATCH 08/14] qapi/parser: enforce strict positioning for "Since:" section In-Reply-To: (John Snow's message of "Tue, 29 Sep 2026 10:25:37 -0400") References: <20260928223657.2303684-1-jsnow@redhat.com> <20260928223657.2303684-9-jsnow@redhat.com> <871pacxlpq.fsf@pond.sub.org> Date: Tue, 29 Sep 2026 17:04:50 +0200 Message-ID: <87zex0umi5.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 9 X-Spam_score: 0.9 X-Spam_bar: / X-Spam_report: (0.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.341, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org John Snow writes: > On Tue, Sep 29, 2026, 8:53=E2=80=AFAM Markus Armbruster wrote: > >> John Snow writes: >> >> > This patch finalizes the total ordering of all QAPI documentation >> > block sections. >> > >> > ... Except TODO, which can still be wherever. >> > >> > Signed-off-by: John Snow >> > --- >> > scripts/qapi/parser.py | 2 +- >> > 1 file changed, 1 insertion(+), 1 deletion(-) >> > >> > diff --git a/scripts/qapi/parser.py b/scripts/qapi/parser.py >> > index 8b331aa0673..c14bff2cbc3 100644 >> > --- a/scripts/qapi/parser.py >> > +++ b/scripts/qapi/parser.py >> > @@ -552,7 +552,7 @@ def _tag_check(this: Union['QAPIDoc.Kind', str]) -> >> None: >> > if isinstance(this, str): >> > this =3D QAPIDoc.Kind.from_string(this) >> > >> > - if this in (QAPIDoc.Kind.TODO, QAPIDoc.Kind.SINCE): >> > + if this =3D=3D QAPIDoc.Kind.TODO: >> > return >> > >> > if this.value < last_ordered_section.value: >> >> The check for duplicate RETURNS, ERRORS, SINCE in new_tagged_section() >> is now technically redundant. Deleting it would make the error message >> worse, though. Do we care? >> > > I wondered that, and wasn't sure. I left them in for now because I was > being conservative with regards to not messing up existing unit tests. > > I suspect your feelings will become clear when we start adding unit tests > for the new error cases. > > Sound about right? Yes. No need to decide now. Better to stay focused.