From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F4574F052F for ; Tue, 8 Sep 2026 10:03:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788861825; cv=none; b=itPDdYfI8H6TaUTZ34LTdkSBXkOHNLjm7Vjt+FFFDeHyc5i8nGrTBtp/fmwfONMw5sa7/RBmSiN7i7CTS2e/bQe9gQ+5z9aXXa1zfJ7VnTsmOuGAv9WC/5/H9BUFeAMYXvtN+NPOVYMv3OGiG1RfCmfOe3x1eASIzZW2o49yT5Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788861825; c=relaxed/simple; bh=5vAQX4mLQwg3bgyjWIDegZmml35dIae71Cu53YVyKVc=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=STEeYWUuvwkFjsoQOckesNgxy4f2tCq3tGT8fOxgNnXNr+fx59mAd1uZUrHD+QkuQcvFMCNz8yzeL1CpMpxTM3PgfuPdoEDANKawo9r5NhNB2/A74cCTQFa5yommHGszcTMc7W4wRbJC1G4J5C8+MqQcJYJr7EPf42y4+G84HT8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=HJxw7a5n; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="HJxw7a5n" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id A1D9A1A1A56; Tue, 8 Sep 2026 10:03:41 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 73C25603C4; Tue, 8 Sep 2026 10:03:41 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 9C87711C7AF5C; Tue, 8 Sep 2026 12:03:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1788861816; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=5vAQX4mLQwg3bgyjWIDegZmml35dIae71Cu53YVyKVc=; b=HJxw7a5n7JiOtutr1aQa1jZOAcwYz7vUl4NtBmXInV72w47M2bbpX/gqsgpboIQx2ttkkD uJhck1Odhe6MP98SkTQKScFMRfE+5rZvf2rZimWdm5MoC+P3Vt1g8SUjbHeVIGdvRCwoO3 ZbuzkTmBrjV6OMhxCdmzmvHQ/A6D8ohLa4PtjAqD7VLGrwY+PRcX7UZ2YBzXC3FGJ0HrxZ wLeFInhRpblg7OiYJyNlVTfsWzs8Qv1eFkR+N9jQ8iDBUhTHmI+JplH6lx4pGdlSV5BA60 hhUYLGMmQCeKzYfHZ5VZTkgd4in2hMlAyW681J1LPsot4e024AN+k71R7E96Ew== From: Miquel Raynal To: James Hilliard Cc: Richard Weinberger , Vignesh Raghavendra , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Boris Brezillon , linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v2] mtd: rawnand: sunxi: fit maximized ECC step to page size In-Reply-To: <20260904-submit-sunxi-nand-ecc-step-validation-v2-1-6e3ba6200948@gmail.com> (James Hilliard's message of "Fri, 04 Sep 2026 16:39:27 -0600") References: <20260904-submit-sunxi-nand-ecc-step-validation-v2-1-6e3ba6200948@gmail.com> User-Agent: mu4e 1.12.12; emacs 30.2 Date: Tue, 08 Sep 2026 12:03:33 +0200 Message-ID: <87zexst5ze.fsf@bootlin.com> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Last-TLS-Session-Version: TLSv1.3 Hello James, On 04/09/2026 at 16:39:27 -06, James Hilliard w= rote: > When nand-ecc-maximize is set, the driver unconditionally selects a > 1024-byte ECC step. A NAND with a 512-byte page consequently produces > zero ECC steps before the available OOB bytes are divided by the step > count. > > The older sunxi NAND controllers support 512-byte ECC blocks. Select the > smaller of the page size and the preferred 1024-byte step, using a > 512-byte step for a 512-byte page while retaining 1024-byte steps for > larger pages. Unsupported smaller steps and controllers without > 512-byte support continue to be rejected by the existing checks. > > Fixes: 4796d8655915 ("mtd: nand: sunxi: Support ECC maximization") > Cc: stable@vger.kernel.org > Signed-off-by: James Hilliard As reported by Sashiko, there is another use of 1024 down the road which must be modified accordingly. Although, in practice, 512-byte page NANDs have disappeared for quite some time, so this is a theoretical fix more than a real problem. Thanks, Miqu=C3=A8l From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CAF44C79F82 for ; Tue, 8 Sep 2026 10:03:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zNf77UU8ZlCf9tUagBoLR/E9qAseoezf1M936+84pJA=; b=cgEs+sA5JP3/he C9rgzFlAAfv/9IrwD1lOd0jeqXA09G/gbv/z0ZOehjAgR0xTyrpAtDuYhMR8kCP3oNntfDF4X3p0r 4mWJNkmPtGXGyoN2Sir5uJDDFM1tChpT0kZHsJZy1O8/sBGsyO9EqLNLRCA4iojlogLWXEv34dP6a 95OzUQrAWHr2vGZtudcNv2loN05H8b0QMMaQNmA+VFSTBcfBFY21zVifAY3toDPqjSbZmIOdhYX5O yjzAAi1gT5Wpjln0tTxZt0I6/0/l2MLxvR3ujqeP7GfQOEIjTQBixk0LC/YiPoVNbSU36X12vK7Oe 8jfCbc7rDIZq2c9Yqsuw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x3sg9-00000008inB-0Ze3; Tue, 08 Sep 2026 10:03:49 +0000 Received: from smtpout-02.galae.net ([185.246.84.56]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x3sg5-00000008ilM-2Sma; Tue, 08 Sep 2026 10:03:47 +0000 Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id A1D9A1A1A56; Tue, 8 Sep 2026 10:03:41 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 73C25603C4; Tue, 8 Sep 2026 10:03:41 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 9C87711C7AF5C; Tue, 8 Sep 2026 12:03:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1788861816; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=5vAQX4mLQwg3bgyjWIDegZmml35dIae71Cu53YVyKVc=; b=HJxw7a5n7JiOtutr1aQa1jZOAcwYz7vUl4NtBmXInV72w47M2bbpX/gqsgpboIQx2ttkkD uJhck1Odhe6MP98SkTQKScFMRfE+5rZvf2rZimWdm5MoC+P3Vt1g8SUjbHeVIGdvRCwoO3 ZbuzkTmBrjV6OMhxCdmzmvHQ/A6D8ohLa4PtjAqD7VLGrwY+PRcX7UZ2YBzXC3FGJ0HrxZ wLeFInhRpblg7OiYJyNlVTfsWzs8Qv1eFkR+N9jQ8iDBUhTHmI+JplH6lx4pGdlSV5BA60 hhUYLGMmQCeKzYfHZ5VZTkgd4in2hMlAyW681J1LPsot4e024AN+k71R7E96Ew== From: Miquel Raynal To: James Hilliard Cc: Richard Weinberger , Vignesh Raghavendra , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Boris Brezillon , linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v2] mtd: rawnand: sunxi: fit maximized ECC step to page size In-Reply-To: <20260904-submit-sunxi-nand-ecc-step-validation-v2-1-6e3ba6200948@gmail.com> (James Hilliard's message of "Fri, 04 Sep 2026 16:39:27 -0600") References: <20260904-submit-sunxi-nand-ecc-step-validation-v2-1-6e3ba6200948@gmail.com> User-Agent: mu4e 1.12.12; emacs 30.2 Date: Tue, 08 Sep 2026 12:03:33 +0200 Message-ID: <87zexst5ze.fsf@bootlin.com> MIME-Version: 1.0 X-Last-TLS-Session-Version: TLSv1.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260908_030345_763979_C7C0B046 X-CRM114-Status: GOOD ( 10.21 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGVsbG8gSmFtZXMsCgpPbiAwNC8wOS8yMDI2IGF0IDE2OjM5OjI3IC0wNiwgSmFtZXMgSGlsbGlh cmQgPGphbWVzLmhpbGxpYXJkMUBnbWFpbC5jb20+IHdyb3RlOgoKPiBXaGVuIG5hbmQtZWNjLW1h eGltaXplIGlzIHNldCwgdGhlIGRyaXZlciB1bmNvbmRpdGlvbmFsbHkgc2VsZWN0cyBhCj4gMTAy NC1ieXRlIEVDQyBzdGVwLiBBIE5BTkQgd2l0aCBhIDUxMi1ieXRlIHBhZ2UgY29uc2VxdWVudGx5 IHByb2R1Y2VzCj4gemVybyBFQ0Mgc3RlcHMgYmVmb3JlIHRoZSBhdmFpbGFibGUgT09CIGJ5dGVz IGFyZSBkaXZpZGVkIGJ5IHRoZSBzdGVwCj4gY291bnQuCj4KPiBUaGUgb2xkZXIgc3VueGkgTkFO RCBjb250cm9sbGVycyBzdXBwb3J0IDUxMi1ieXRlIEVDQyBibG9ja3MuIFNlbGVjdCB0aGUKPiBz bWFsbGVyIG9mIHRoZSBwYWdlIHNpemUgYW5kIHRoZSBwcmVmZXJyZWQgMTAyNC1ieXRlIHN0ZXAs IHVzaW5nIGEKPiA1MTItYnl0ZSBzdGVwIGZvciBhIDUxMi1ieXRlIHBhZ2Ugd2hpbGUgcmV0YWlu aW5nIDEwMjQtYnl0ZSBzdGVwcyBmb3IKPiBsYXJnZXIgcGFnZXMuIFVuc3VwcG9ydGVkIHNtYWxs ZXIgc3RlcHMgYW5kIGNvbnRyb2xsZXJzIHdpdGhvdXQKPiA1MTItYnl0ZSBzdXBwb3J0IGNvbnRp bnVlIHRvIGJlIHJlamVjdGVkIGJ5IHRoZSBleGlzdGluZyBjaGVja3MuCj4KPiBGaXhlczogNDc5 NmQ4NjU1OTE1ICgibXRkOiBuYW5kOiBzdW54aTogU3VwcG9ydCBFQ0MgbWF4aW1pemF0aW9uIikK PiBDYzogc3RhYmxlQHZnZXIua2VybmVsLm9yZwo+IFNpZ25lZC1vZmYtYnk6IEphbWVzIEhpbGxp YXJkIDxqYW1lcy5oaWxsaWFyZDFAZ21haWwuY29tPgoKQXMgcmVwb3J0ZWQgYnkgU2FzaGlrbywg dGhlcmUgaXMgYW5vdGhlciB1c2Ugb2YgMTAyNCBkb3duIHRoZSByb2FkIHdoaWNoCm11c3QgYmUg bW9kaWZpZWQgYWNjb3JkaW5nbHkuIEFsdGhvdWdoLCBpbiBwcmFjdGljZSwgNTEyLWJ5dGUgcGFn ZSBOQU5EcwpoYXZlIGRpc2FwcGVhcmVkIGZvciBxdWl0ZSBzb21lIHRpbWUsIHNvIHRoaXMgaXMg YSB0aGVvcmV0aWNhbCBmaXggbW9yZQp0aGFuIGEgcmVhbCBwcm9ibGVtLgoKVGhhbmtzLApNaXF1 w6hsCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KTGludXggTVREIGRpc2N1c3Npb24gbWFpbGluZyBsaXN0Cmh0dHA6Ly9saXN0cy5pbmZyYWRl YWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtbXRkLwo=