Re: [PATCH] disas: converts malloc to g_malloc0

[Markus Armbruster <armbru@redhat.com>]

Christian <christianslima@proton.me> writes:

> Hi, Markus!
>
>> Any particular reason to initialize, or is it "just in case"?
>
> It's a just in case, the next lines initialize the values. 

Suggest to mention that in the commit message, just to be perfectly
clear.

>> g_new0(struct m68k_opcode, m68k_numopcodes) would be more obviously
>> safe, because it checks the multiplication for for overflow.
>
> When I tried g_new0, but the first argument is a pointer to `struct m68k_opcode`, but it gives me an error, so I just used g_malloc0 instead. If I pass just the struct as the first argument gives me the same result as using the g_malloc0?

g_new0(T, N) allocates an array T[N].  The macro's return value is a T
*.  So, g_new0(struct m68k_opcode *, m68k_numopcodes) returns struct
m68k_opcode **, which fails type checking.  Good, because it's indeed
wrong: you want an array of T, not an array of T *.

Details at <https://docs.gtk.org/glib/func.new0.html>.

Questions?