All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Corbet <corbet@lwn.net>
To: WangYuli <wangyuli@aosc.io>,
	Chen-Shi-Hong <eric039eric@gmail.com>,
	linux@leemhuis.info
Cc: skhan@linuxfoundation.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] docs: reporting-issues: replace "these advices" with "all of this advice"
Date: Thu, 14 May 2026 06:18:35 -0600	[thread overview]
Message-ID: <87zf22uquc.fsf@trenco.lwn.net> (raw)
In-Reply-To: <e2cced37-58ea-4678-a586-97f9a6db7e9d@aosc.io>

WangYuli <wangyuli@aosc.io> writes:

> I searched the kernel tree for the misspelling "advices" (the word
> "advice" is uncountable) and found the following occurrences:
>
> "
>
>    >rg-i "advices"
>
> tools/perf/trace/beauty/mmap.c
>    68:       static DEFINE_STRARRAY(madvise_advices, "MADV_");
>    70:       if (behavior < strarray__madvise_advices.nr_entries && 
> strarray__madvise_advices.entries[behavior] != NULL)
>    71:               return scnprintf(bf, size, "MADV_%s", 
> strarray__madvise_advices.entries[behavior]);

Please, no.  If you start churning the code in that way you will
certainly get pushback.  Typo fixes are a fine way to learn the process,
but I really hope that contributors will move on quickly to more
substantial work.

Thanks,

jon

  reply	other threads:[~2026-05-14 12:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-14  8:27 [PATCH v4] docs: reporting-issues: replace "these advices" with "all of this advice" Chen-Shi-Hong
2026-05-14  8:56 ` WangYuli
2026-05-14 12:18   ` Jonathan Corbet [this message]
2026-05-14 12:30     ` WangYuli
2026-05-15 13:56 ` Jonathan Corbet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zf22uquc.fsf@trenco.lwn.net \
    --to=corbet@lwn.net \
    --cc=eric039eric@gmail.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@leemhuis.info \
    --cc=skhan@linuxfoundation.org \
    --cc=wangyuli@aosc.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.