From: Takashi Iwai <tiwai@suse.de>
To: Harin Lee <me@harin.net>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: ctxfi: Add fallback to default RSR for S/PDIF
Date: Mon, 06 Apr 2026 10:50:59 +0200 [thread overview]
Message-ID: <87zf3glbf0.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260406074913.217374-1-me@harin.net>
On Mon, 06 Apr 2026 09:49:13 +0200,
Harin Lee wrote:
>
> spdif_passthru_playback_get_resources() uses atc->pll_rate as the RSR
> for the MSR calculation loop. However, pll_rate is only updated in
> atc_pll_init() and not in hw_pll_init(), so it remains 0 after the
> card init.
>
> When spdif_passthru_playback_setup() skips atc_pll_init() for
> 32000 Hz, (rsr * desc.msr) always becomes 0, causing the loop to spin
> indefinitely.
>
> Add fallback to use atc->rsr when atc->pll_rate is 0. This reflects
> the hardware state, since hw_card_init() already configures the PLL
> to the default RSR.
>
> Fixes: 8cc72361481f ("ALSA: SB X-Fi driver merge")
> Cc: stable@vger.kernel.org
> Signed-off-by: Harin Lee <me@harin.net>
Applied to for-next branch now. Thanks.
Takashi
prev parent reply other threads:[~2026-04-06 8:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-06 7:49 [PATCH] ALSA: ctxfi: Add fallback to default RSR for S/PDIF Harin Lee
2026-04-06 8:50 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zf3glbf0.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=me@harin.net \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.