From: Petr Machata <petrm@nvidia.com>
To: Ioana Ciornei <ioana.ciornei@nxp.com>
Cc: <netdev@vger.kernel.org>, Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
<linux-kernel@vger.kernel.org>, <petrm@nvidia.com>,
<willemb@google.com>
Subject: Re: [PATCH net-next v3 9/9] selftests: drivers: hw: add test for the ethtool standard counters
Date: Fri, 20 Mar 2026 12:41:23 +0100 [thread overview]
Message-ID: <87zf427mnl.fsf@nvidia.com> (raw)
In-Reply-To: <20260319160410.2515105-10-ioana.ciornei@nxp.com>
Ioana Ciornei <ioana.ciornei@nxp.com> writes:
> Add a new selftest - ethtool_std_stats.sh - which validates the
> eth-ctrl, eth-mac and pause standard statistics exported by an
> interface. Collision related eth-mac counters as well as the error ones
> will be checked against zero since that is the most likely correct
> scenario.
>
> The central part of this patch is the traffic_test() function which
> gathers the 'before' counter values, sends a batch of traffic and then
> interrogates again the same counters in order to determine if the delta
> is on target. The function receives an array through which the caller
> can request what counters to be interrogated and, for each of them, what
> is their target delta value.
>
> The output from this selftest looks as follows on a LX2160ARDB board:
>
> $ ./run_kselftest.sh -t drivers/net/hw:ethtool_std_stats.sh
> TAP version 13
> 1..1
> # timeout set to 0
> # selftests: drivers/net/hw: ethtool_std_stats.sh
> # TEST: eth-ctrl-MACControlFramesTransmitted on endpmac17 [ OK ]
> # TEST: eth-ctrl-MACControlFramesReceived on endpmac17 [ OK ]
> # TEST: eth-mac-FrameCheckSequenceErrors on endpmac17 [ OK ]
> # TEST: eth-mac-AlignmentErrors on endpmac17 [ OK ]
> # TEST: eth-mac-FramesLostDueToIntMACXmitError on endpmac17 [ OK ]
> # TEST: eth-mac-CarrierSenseErrors on endpmac17 (not supported) [SKIP]
> # TEST: eth-mac-FramesLostDueToIntMACRcvError on endpmac17 [ OK ]
> # TEST: eth-mac-InRangeLengthErrors on endpmac17 (not supported) [SKIP]
> # TEST: eth-mac-OutOfRangeLengthField on endpmac17 (not supported) [SKIP]
> # TEST: eth-mac-FrameTooLongErrors on endpmac17 (not supported) [SKIP]
> # TEST: eth-mac-FramesAbortedDueToXSColls on endpmac17 (not supported) [SKIP]
> # TEST: eth-mac-SingleCollisionFrames on endpmac17 (not supported) [SKIP]
> # TEST: eth-mac-MultipleCollisionFrames on endpmac17 (not supported) [SKIP]
> # TEST: eth-mac-FramesWithDeferredXmissions on endpmac17 (not supported) [SKIP]
> # TEST: eth-mac-LateCollisions on endpmac17 (not supported) [SKIP]
> # TEST: eth-mac-FramesWithExcessiveDeferral on endpmac17 (not supported) [SKIP]
> # TEST: eth-mac-BroadcastFramesXmittedOK on endpmac17 [ OK ]
> # TEST: eth-mac-OctetsTransmittedOK on endpmac17 [ OK ]
> # TEST: eth-mac-BroadcastFramesReceivedOK on endpmac17 [ OK ]
> # TEST: eth-mac-OctetsReceivedOK on endpmac17 [ OK ]
> # TEST: eth-mac-FramesTransmittedOK on endpmac17 [ OK ]
> # TEST: eth-mac-MulticastFramesXmittedOK on endpmac17 [ OK ]
> # TEST: eth-mac-FramesReceivedOK on endpmac17 [ OK ]
> # TEST: eth-mac-MulticastFramesReceivedOK on endpmac17 [ OK ]
> # TEST: pause-tx_pause_frames on endpmac17 [ OK ]
> # TEST: pause-rx_pause_frames on endpmac17 [ OK ]
> ok 1 selftests: drivers/net/hw: ethtool_std_stats.sh # SKIP
>
> Please note that not all MACs are counting the software injected pause
> frames as real Tx pause. For example, on a LS1028ARDB the selftest
> output will reflect the fact that neither the ENETC MAC, nor the Felix
> switch MAC are able to detect Tx pause frames injected by software.
>
> $ ./run_kselftest.sh -t drivers/net/hw:ethtool_std_stats.sh
> (...)
> # TEST: pause-tx_pause_frames on eno0 (software sent pause frames not detected) [XFAIL]
> # TEST: pause-rx_pause_frames on eno0 [ OK ]
>
> Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
Acked-by: Petr Machata <petrm@nvidia.com>
next prev parent reply other threads:[~2026-03-20 11:42 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-19 16:04 [PATCH net-next v3 0/9] selftests: drivers: bash support for remote traffic generators Ioana Ciornei
2026-03-19 16:04 ` [PATCH net-next v3 1/9] selftests: forwarding: extend ethtool_std_stats_get with pause statistics Ioana Ciornei
2026-03-20 11:15 ` Petr Machata
2026-03-20 11:20 ` Petr Machata
2026-03-20 11:25 ` Ioana Ciornei
2026-03-19 16:04 ` [PATCH net-next v3 2/9] selftests: net: add helpers for running a command on other targets Ioana Ciornei
2026-03-20 10:58 ` Petr Machata
2026-03-20 13:12 ` Ioana Ciornei
2026-03-20 16:05 ` Petr Machata
2026-03-19 16:04 ` [PATCH net-next v3 3/9] selftests: net: extend lib.sh to parse drivers/net/net.config Ioana Ciornei
2026-03-20 10:19 ` Petr Machata
2026-03-20 13:28 ` Ioana Ciornei
2026-03-20 15:35 ` Petr Machata
2026-03-19 16:04 ` [PATCH net-next v3 4/9] selftests: net: update some helpers to use run_on Ioana Ciornei
2026-03-20 11:22 ` Petr Machata
2026-03-20 12:55 ` Ioana Ciornei
2026-03-19 16:04 ` [PATCH net-next v3 5/9] selftests: drivers: hw: cleanup shellcheck warnings in the rmon test Ioana Ciornei
2026-03-20 11:29 ` Petr Machata
2026-03-19 16:04 ` [PATCH net-next v3 6/9] selftests: drivers: hw: test rmon counters only on first interface Ioana Ciornei
2026-03-20 11:31 ` Petr Machata
2026-03-19 16:04 ` [PATCH net-next v3 7/9] selftests: drivers: hw: replace counter upper limit with UINT32_MAX in rmon test Ioana Ciornei
2026-03-20 11:33 ` Petr Machata
2026-03-19 16:04 ` [PATCH net-next v3 8/9] selftests: drivers: hw: update ethtool_rmon to work with a single local interface Ioana Ciornei
2026-03-20 11:38 ` Petr Machata
2026-03-19 16:04 ` [PATCH net-next v3 9/9] selftests: drivers: hw: add test for the ethtool standard counters Ioana Ciornei
2026-03-20 11:41 ` Petr Machata [this message]
2026-03-21 3:17 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zf427mnl.fsf@nvidia.com \
--to=petrm@nvidia.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=ioana.ciornei@nxp.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.