From: Fabiano Rosas <farosas@suse.de>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: peterx@redhat.com
Subject: Re: [PATCH 3/3] migration/postcopy-ram: Improve error reporting after loadvm failure
Date: Mon, 17 Nov 2025 12:50:46 -0300 [thread overview]
Message-ID: <87zf8kbquh.fsf@suse.de> (raw)
In-Reply-To: <20251115083500.2753895-4-armbru@redhat.com>
Markus Armbruster <armbru@redhat.com> writes:
> One of two error messages show __func__. Drop it; it doesn't help
> users, and developers can grep for the message. This also permits
> de-duplicating the code to prepend to the error message.
>
> Both error messages show a numeric error code. I doubt that's
> helpful, but I'm leaving it alone.
>
> Use error_append_hint() for explaining that some dirty bitmaps may be
> lost. Polish the prose.
>
> Don't faff around with g_clear_pointer(), it's not worth its keep
> here.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Fabiano Rosas <farosas@suse.de>
next prev parent reply other threads:[~2025-11-17 15:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-15 8:34 [PATCH 0/3] migration: Error fixes and improvements Markus Armbruster
2025-11-15 8:34 ` [PATCH 1/3] migration: Plug memory leaks after migrate_set_error() Markus Armbruster
2025-11-15 8:34 ` [PATCH 2/3] migration: Use warn_reportf_err() where appropriate Markus Armbruster
2025-11-17 15:47 ` Fabiano Rosas
2025-11-15 8:35 ` [PATCH 3/3] migration/postcopy-ram: Improve error reporting after loadvm failure Markus Armbruster
2025-11-17 15:50 ` Fabiano Rosas [this message]
2025-11-17 16:03 ` [PATCH 0/3] migration: Error fixes and improvements Peter Xu
2025-11-18 7:44 ` Markus Armbruster
2025-11-18 17:35 ` Peter Xu
2025-11-19 7:45 ` Markus Armbruster
2025-11-19 20:58 ` Peter Xu
2025-11-20 10:30 ` Migration and the Job abstraction (was: [PATCH 0/3] migration: Error fixes and improvements) Markus Armbruster
2025-11-20 12:16 ` Kevin Wolf
2025-11-24 22:48 ` Peter Xu
2025-12-02 13:16 ` Migration and the Job abstraction Markus Armbruster
2025-12-02 19:16 ` Peter Xu
2025-11-21 12:38 ` [PATCH 0/3] migration: Error fixes and improvements Fabiano Rosas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zf8kbquh.fsf@suse.de \
--to=farosas@suse.de \
--cc=armbru@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.