Re: [OE-core] [PATCH] lib/oe/package: Add debug_frame support

[Mathieu Othacehe <othacehe@gnu.org>]

Hello Quentin,

Thanks for having a look!

> Would be nice to document this variable in the yocto-docs
> (https://git.yoctoproject.org/yocto-docs/). Would you mind sending us a patch
> once this lands (or if there's a v2, maybe alongside or at the same time?)?
> That would be for the variable glossary at the very least. Thanks!

Sure, I will send a documentation patch right after that one is merged.

> thought: would there be a use-case for keeping other sections?
>
> Therefore, instead of having multiple PACKAGE_KEEP_xxx variables, should we
> have PACKAGE_KEEP_SECTION = ".debug_frame"?

I guess you are right, and being able to keep some specific sections
besides .debug_frame can prove to be helpful in the future. I will
rework a bit this commit in that direction.

I think it would still be interesting to have a PACKAGE_KEEP_DEBUG_FRAME
variable around because that is more convenient for the user than
PACKAGE_KEEP_SECTION = ".debug_frame".

However, we can maybe keep both, by doing something like:

if bb.utils.to_boolean(d.getVar("PACKAGE_KEEP_DEBUG_FRAME"))
        d.appendVar("PACKAGE_KEEP_SECTION", ".debug_frame")

Would that be OK?

Thanks,

Mathieu