All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Nitin Gote <nitin.r.gote@intel.com>, intel-gfx@lists.freedesktop.org
Cc: andi.shyti@intel.com, Nitin Gote <nitin.r.gote@intel.com>
Subject: Re: [PATCH v1 7/8] drm/i915/display: fix typos in i915/display files
Date: Tue, 07 Jan 2025 14:51:58 +0200	[thread overview]
Message-ID: <87zfk2lrbl.fsf@intel.com> (raw)
In-Reply-To: <20250106103037.1401847-8-nitin.r.gote@intel.com>

On Mon, 06 Jan 2025, Nitin Gote <nitin.r.gote@intel.com> wrote:
> @@ -8440,7 +8440,7 @@ intel_mode_valid_max_plane_size(struct drm_i915_private *dev_priv,
>  
>  	/*
>  	 * Most people will probably want a fullscreen
> -	 * plane so let's not advertize modes that are
> +	 * plane so let's not advertise modes that are
>  	 * too big for that.
>  	 */
>  	if (DISPLAY_VER(dev_priv) >= 30) {

I appreciate the typo fixes, but there's an explicit policy that certain
things are not typos and should not be fixed. This includes British
vs. American spelling.

Can you not tell codespell that?

> @@ -2552,7 +2552,7 @@ intel_dp_compute_config_limits(struct intel_dp *intel_dp,
>  		 * seem to suggest we should do otherwise.
>  		 *
>  		 * Use the maximum clock and number of lanes the eDP panel
> -		 * advertizes being capable of in case the initial fast
> +		 * advertises being capable of in case the initial fast
>  		 * optimal params failed us. The panels are generally
>  		 * designed to support only a single clock and lane
>  		 * configuration, and typically on older panels these

Ditto.

> @@ -442,8 +444,10 @@ static int intel_overlay_off(struct intel_overlay *overlay)
>  	return i915_active_wait(&overlay->last_flip);
>  }
>  
> -/* recover from an interruption due to a signal
> - * We have to be careful not to repeat work forever an make forward progess. */
> +/*
> + * recover from an interruption due to a signal
> + * We have to be careful not to repeat work forever an make forward progress.
> + */

If you're changing the comment format while at it, might as well
capitalize the first sentence and add a period.


BR,
Jani.


-- 
Jani Nikula, Intel

  reply	other threads:[~2025-01-07 12:52 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-06 10:30 [PATCH v1 0/8] Fix all typos in i915 Nitin Gote
2025-01-06 10:30 ` [PATCH v1 1/8] drm/i915/gt: fix typos in i915/gt files Nitin Gote
2025-01-07 10:48   ` Andi Shyti
2025-01-06 10:30 ` [PATCH v1 2/8] drm/i915/gvt: fix typos in i915/gvt files Nitin Gote
2025-01-07 11:20   ` Andi Shyti
2025-01-06 10:30 ` [PATCH v1 3/8] drm/i915/gem: fix typos in i915/gem files Nitin Gote
2025-01-07 12:37   ` Andi Shyti
2025-01-06 10:30 ` [PATCH v1 4/8] drm/i915/pxp: fix typos in i915/pxp files Nitin Gote
2025-01-07 12:38   ` Andi Shyti
2025-01-06 10:30 ` [PATCH v1 5/8] drm/i915/selftests: fix typos in i915/selftests files Nitin Gote
2025-01-07 13:55   ` Andi Shyti
2025-01-06 10:30 ` [PATCH v1 6/8] drm/i915/soc: fix typos in i915/soc files Nitin Gote
2025-01-07 13:56   ` Andi Shyti
2025-01-06 10:30 ` [PATCH v1 7/8] drm/i915/display: fix typos in i915/display files Nitin Gote
2025-01-07 12:51   ` Jani Nikula [this message]
2025-01-09  7:58     ` Gote, Nitin R
2025-01-06 10:30 ` [PATCH v1 8/8] drm/i915: fix typos in drm/i915 files Nitin Gote
2025-01-07 14:34   ` Andi Shyti
2025-01-06 11:33 ` ✗ Fi.CI.SPARSE: warning for Fix all typos in i915 Patchwork
2025-01-06 11:35 ` ✓ i915.CI.BAT: success " Patchwork
2025-01-06 16:10 ` ✓ i915.CI.Full: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zfk2lrbl.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=andi.shyti@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=nitin.r.gote@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.