From: Takashi Iwai <tiwai@suse.de>
To: Eric Biggers <ebiggers@kernel.org>
Cc: linux-sound@vger.kernel.org, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
linux-kernel@vger.kernel.org,
Shenghao Ding <shenghao-ding@ti.com>, Kevin Lu <kevin-lu@ti.com>,
Baojun Xu <baojun.xu@ti.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda/tas2781: select CRC32 instead of CRC32_SARWATE
Date: Mon, 21 Oct 2024 09:21:20 +0200 [thread overview]
Message-ID: <87zfmxj4zz.wl-tiwai@suse.de> (raw)
In-Reply-To: <20241020175624.7095-1-ebiggers@kernel.org>
On Sun, 20 Oct 2024 19:56:24 +0200,
Eric Biggers wrote:
>
> From: Eric Biggers <ebiggers@google.com>
>
> Fix the kconfig option for the tas2781 HDA driver to select CRC32 rather
> than CRC32_SARWATE. CRC32_SARWATE is an option from the kconfig
> 'choice' that selects the specific CRC32 implementation. Selecting a
> 'choice' option seems to have no effect, but even if it did work, it
> would be incorrect for a random driver to override the user's choice.
> CRC32 is the correct option to select for crc32() to be available.
>
> Fixes: 5be27f1e3ec9 ("ALSA: hda/tas2781: Add tas2781 HDA driver")
> Cc: stable@vger.kernel.org
> Signed-off-by: Eric Biggers <ebiggers@google.com>
Thanks, applied now.
Takashi
prev parent reply other threads:[~2024-10-21 7:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-20 17:56 [PATCH] ALSA: hda/tas2781: select CRC32 instead of CRC32_SARWATE Eric Biggers
2024-10-21 7:21 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zfmxj4zz.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=baojun.xu@ti.com \
--cc=ebiggers@kernel.org \
--cc=kevin-lu@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=shenghao-ding@ti.com \
--cc=stable@vger.kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.