All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org,  qemu-trivial@nongnu.org
Subject: Re: [PATCH] include: Fix typo in name of MAKE_IDENTFIER macro
Date: Thu, 01 Aug 2024 13:34:56 +0200	[thread overview]
Message-ID: <87zfpwcw7z.fsf@pond.sub.org> (raw)
In-Reply-To: <20240801102516.3843780-1-peter.maydell@linaro.org> (Peter Maydell's message of "Thu, 1 Aug 2024 11:25:16 +0100")

Peter Maydell <peter.maydell@linaro.org> writes:

> In commit bb71846325e23 we added some macro magic to avoid
> variable-shadowing when using some of our more complicated
> macros. One of the internal components of this is a macro
> named MAKE_IDENTFIER. Fix the typo in its name: it should
> be MAKE_IDENTIFIER.
>
> Commit created with
>  sed -i -e 's/MAKE_IDENTFIER/MAKE_IDENTIFIER/g' include/qemu/*.h include/qapi/qmp/qobject.h
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>

Can't believe I messed this up, but git proves I did %-}

Reviewed-by: Markus Armbruster <armbru@redhat.com>

Thanks!



  reply	other threads:[~2024-08-01 11:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-01 10:25 [PATCH] include: Fix typo in name of MAKE_IDENTFIER macro Peter Maydell
2024-08-01 11:34 ` Markus Armbruster [this message]
2024-08-01 11:52 ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zfpwcw7z.fsf@pond.sub.org \
    --to=armbru@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.