From: Kalle Valo <kvalo@kernel.org>
To: Marc Gonzalez <mgonzalez@freebox.fr>
Cc: Bjorn Andersson <andersson@kernel.org>,
Jeff Johnson <quic_jjohnson@quicinc.com>,
ath10k <ath10k@lists.infradead.org>,
wireless <linux-wireless@vger.kernel.org>,
DT <devicetree@vger.kernel.org>,
MSM <linux-arm-msm@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Pierre-Hugues Husson <phhusson@freebox.fr>,
Arnaud Vrac <avrac@freebox.fr>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Jami Kettunen <jamipkettunen@gmail.com>,
Jeffrey Hugo <quic_jhugo@quicinc.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Alexey Minnekhanov <alexeymin@postmarketos.org>
Subject: Re: [PATCH v3 1/3] dt-bindings: net: wireless: ath10k: add qcom,no-msa-ready-indicator prop
Date: Tue, 28 May 2024 13:11:10 +0300 [thread overview]
Message-ID: <87zfsa6ybl.fsf@kernel.org> (raw)
In-Reply-To: <3464a980-36a7-4ed2-b2dc-be8fd9091b06@freebox.fr> (Marc Gonzalez's message of "Tue, 28 May 2024 11:54:37 +0200")
Marc Gonzalez <mgonzalez@freebox.fr> writes:
> On 13/05/2024 16:16, Kalle Valo wrote:
>
>> Marc Gonzalez wrote:
>>
>>> The ath10k driver waits for an "MSA_READY" indicator
>>> to complete initialization. If the indicator is not
>>> received, then the device remains unusable.
>>>
>>> cf. ath10k_qmi_driver_event_work()
>>>
>>> Several msm8998-based devices are affected by this issue.
>>> Oddly, it seems safe to NOT wait for the indicator, and
>>> proceed immediately when QMI_EVENT_SERVER_ARRIVE.
>>>
>>> Jeff Johnson wrote:
>>>
>>> The feedback I received was "it might be ok to change all ath10k qmi
>>> to skip waiting for msa_ready", and it was pointed out that ath11k
>>> (and ath12k) do not wait for it.
>>>
>>> However with so many deployed devices, "might be ok" isn't a strong
>>> argument for changing the default behavior.
>>>
>>> Kalle Valo first suggested setting a bit in firmware-5.bin to trigger
>>> work-around in the driver. However, firmware-5.bin is parsed too late.
>>> So we are stuck with a DT property.
>>>
>>> Signed-off-by: Marc Gonzalez <mgonzalez@freebox.fr>
>>> Reviewed-by: Bjorn Andersson <quic_bjorande@quicinc.com>
>>> Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com>
>>> Acked-by: Rob Herring (Arm) <robh@kernel.org>
>>> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
>>
>> 2 patches applied to ath-next branch of ath.git, thanks.
>>
>> 71b6e321e302 dt-bindings: net: wireless: ath10k: add
>> qcom,no-msa-ready-indicator prop
>> 6d67d18014a8 wifi: ath10k: do not always wait for MSA_READY indicator
>
> Hello Kalle,
> What version of Linux will these be included in?
> (I don't see them in v6.10-rc1. Are they considered
> a new feature, rather than a fix, and thus 6.11?)
Yeah, these commits will go to v6.11. Because of the multiple trees
involved (ath-next -> wireless-next -> net-next -> linus) we need to
have ath.git pull request ready well before the merge window opens and
these commits missed the last pull request.
Yes, we are slow :)
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2024-05-28 10:11 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-29 14:01 [PATCH v3 0/3] Work around missing MSA_READY indicator for msm8998 devices Marc Gonzalez
2024-04-29 14:04 ` [PATCH v3 1/3] dt-bindings: net: wireless: ath10k: add qcom,no-msa-ready-indicator prop Marc Gonzalez
2024-04-30 2:22 ` Bjorn Andersson
2024-04-30 4:06 ` Kalle Valo
2024-04-30 11:10 ` Marc Gonzalez
2024-05-06 12:16 ` Kalle Valo
2024-05-07 17:03 ` Kalle Valo
2024-05-13 8:47 ` Marc Gonzalez
2024-04-30 14:39 ` Jeff Johnson
2024-05-07 15:05 ` Rob Herring (Arm)
2024-05-13 14:16 ` Kalle Valo
2024-05-28 9:54 ` Marc Gonzalez
2024-05-28 10:11 ` Kalle Valo [this message]
2024-05-28 12:36 ` Marc Gonzalez
2024-05-28 13:34 ` Kalle Valo
2024-04-29 14:06 ` [PATCH v3 2/3] wifi: ath10k: do not always wait for MSA_READY indicator Marc Gonzalez
2024-04-30 2:24 ` Bjorn Andersson
2024-04-30 11:15 ` Marc Gonzalez
2024-04-30 14:39 ` Jeff Johnson
2024-04-29 14:07 ` [PATCH v3 3/3] arm64: dts: qcom: msm8998: set qcom,no-msa-ready-indicator for wifi Marc Gonzalez
2024-04-30 14:40 ` Jeff Johnson
2024-05-06 10:39 ` Marc Gonzalez
2024-05-07 11:06 ` Konrad Dybcio
2024-04-29 23:24 ` [PATCH v3 0/3] Work around missing MSA_READY indicator for msm8998 devices Bryan O'Donoghue
2024-04-30 2:18 ` Bjorn Andersson
2024-05-29 2:01 ` (subset) " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zfsa6ybl.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=alexeymin@postmarketos.org \
--cc=andersson@kernel.org \
--cc=ath10k@lists.infradead.org \
--cc=avrac@freebox.fr \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=jamipkettunen@gmail.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mgonzalez@freebox.fr \
--cc=phhusson@freebox.fr \
--cc=quic_jhugo@quicinc.com \
--cc=quic_jjohnson@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.