From: Kalle Valo <kvalo@kernel.org>
To: Jeff Johnson <quic_jjohnson@quicinc.com>
Cc: Ziyang Huang <hzyitc@outlook.com>, <jjohnson@kernel.org>,
<linux-wireless@vger.kernel.org>, <ath11k@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] wifi: ath11k: fix remapped ce accessing issue on 64bit OS
Date: Thu, 02 May 2024 10:05:37 +0300 [thread overview]
Message-ID: <87zft8elry.fsf@kernel.org> (raw)
In-Reply-To: <6336ffc7-d8ae-4cfd-8b66-d6d91cb0d15e@quicinc.com> (Jeff Johnson's message of "Wed, 1 May 2024 09:56:15 -0700")
Jeff Johnson <quic_jjohnson@quicinc.com> writes:
>> static inline u32 ath11k_ahb_read32(struct ath11k_base *ab, u32 offset)
>> {
>> - return ioread32(ab->mem + offset);
>> + switch (offset & ATH11K_REG_TYPE_MASK) {
>> + case ATH11K_REG_TYPE_NORMAL:
>> + return ioread32(ab->mem + FIELD_GET(ATH11K_REG_OFFSET_MASK, offset));
>> + case ATH11K_REG_TYPE_CE:
>> + return ioread32(ab->mem_ce + FIELD_GET(ATH11K_REG_OFFSET_MASK, offset));
>> + default:
>> + BUG();
>
> you can WARN but you can't BUG (and even WARN is being discouraged)
Yeah, even WARN() is risky especially in a function like this. It can
cause so much log messages so that the wathdog can trigger and reboot
the host.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2024-05-02 7:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-01 16:14 [PATCH] wifi: ath11k: fix remapped ce accessing issue on 64bit OS Ziyang Huang
2024-05-01 16:55 ` Larry Finger
2024-05-02 7:03 ` Kalle Valo
2024-05-01 16:56 ` Jeff Johnson
2024-05-02 7:05 ` Kalle Valo [this message]
2024-05-02 16:24 ` Ziyang Huang
2024-05-02 19:27 ` Sergey Ryazanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zft8elry.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=ath11k@lists.infradead.org \
--cc=hzyitc@outlook.com \
--cc=jjohnson@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_jjohnson@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.