From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C6401C4345F for ; Mon, 15 Apr 2024 11:02:38 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 758D04064E; Mon, 15 Apr 2024 11:02:38 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id XfGAIzUAcOXw; Mon, 15 Apr 2024 11:02:34 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 6CEE6406A9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1713178954; bh=Iup/E2Z1WjEWPfxFDQcDvpZjGXHr6zId0gCi5u7ymqw=; h=From:To:In-Reply-To:References:Date:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=q1NZwNFDIgKchFNdZSek0wTm9BEhFhxDNDp6SFvcHgJydJ2z0Sk9/+UKTUnbI9qZ8 j8AIOzR2v2n2ujdcIPpMHt1v8hd6x7z6rpfkoS5Nifp2A8kRLPWsjVlnZaR3R9zJD4 ref5LIGjaH3jURbtgDFbe1UVZPpMN0qCBFmx2fPeUVQGWS3sztrMg2uETdssbQ/vq2 mrtbANI/ARfadajBc+vMwVqS+j26QGtUtiFa7km1cFgBaXpERAyEJzOZhgvwpzuqOs uJqn0P0xRfm2GADPyPUFHZfIjtnN0OJzOHbkLcw+BN2YJN3wqonDntIKB8kUr/gL1g V0HkizLROATOA== Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp4.osuosl.org (Postfix) with ESMTP id 6CEE6406A9; Mon, 15 Apr 2024 11:02:34 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 275A51BF296 for ; Mon, 15 Apr 2024 11:02:33 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 0FC9D406E5 for ; Mon, 15 Apr 2024 11:02:33 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id q_X7fxBiuN6O for ; Mon, 15 Apr 2024 11:02:28 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2a0a:51c0:0:12e:550::1; helo=galois.linutronix.de; envelope-from=kurt@linutronix.de; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp4.osuosl.org EB742406A7 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org EB742406A7 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by smtp4.osuosl.org (Postfix) with ESMTPS id EB742406A7 for ; Mon, 15 Apr 2024 11:02:17 +0000 (UTC) From: Kurt Kanzenbach To: Lukas Wunner , Roman Lozko In-Reply-To: <877ch0b901.fsf@kurt.kurt.home> References: <20240411-igc_led_deadlock-v1-1-0da98a3c68c5@linutronix.de> <877ch0b901.fsf@kurt.kurt.home> Date: Mon, 15 Apr 2024 13:02:14 +0200 Message-ID: <87zftukhxl.fsf@kurt.kurt.home> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1713178935; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Iup/E2Z1WjEWPfxFDQcDvpZjGXHr6zId0gCi5u7ymqw=; b=YeAUzIjafFVlWbU1pQ9y8y+2P+9UB8Is9zbnnVTOS+U7e9uww22L5/mDdCGNZBYZC/LZqg eb9zKRiAcJuSXfs7akEJRudSoFsUKbEQyn2T73zRTQJvQgON5B8m6Cs+foX+cIg9P13muZ aXyuH8Tg7VqumsZcj4sNJvtv7YMbIkx4pxxAyflu6BolIHAoXMcfx/cwoo4Yo3QzDK2qkW PfKN2Nx0KWkWO8W2FdTj69lq+gkRWOS3ysQC7GKUgIcyim5CnYVPcgJEY9uk+tL4agYeko 631VPRBf+6x8nBafPwK4sxnh4v5hhcyiSK4qDiZhhh23GbaWvEphnMThDHKmmw== X-Mailman-Original-DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1713178935; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Iup/E2Z1WjEWPfxFDQcDvpZjGXHr6zId0gCi5u7ymqw=; b=JTYhWBoSpOWfwwzFaW5Sl9JOi1z+jl3L4JWydwgAzR4GuFjZAzfxsWXaIQt4Bpiq5puYAF 7BGSjlR1WORM5ADA== X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dmarc=pass (p=none dis=none) header.from=linutronix.de X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=linutronix.de header.i=@linutronix.de header.a=rsa-sha256 header.s=2020 header.b=YeAUzIja; dkim=pass header.d=linutronix.de header.i=@linutronix.de header.a=ed25519-sha256 header.s=2020e header.b=JTYhWBoS Subject: Re: [Intel-wired-lan] [PATCH iwl-net] igc: Fix deadlock on module removal X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Sasha Neftin , intel-wired-lan@lists.osuosl.org, Eric Dumazet , Tony Nguyen , netdev@vger.kernel.org, Jakub Kicinski , Paolo Abeni , "David S. Miller" Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" --=-=-= Content-Type: text/plain Lukas, >> I would have been happy to submit a patch myself, I was waiting >> for a Tested-by from Roman or you. > > Perfect. I was wondering why you are not submitting the patch > yourself. Then, please go ahead and submit the patch. Feel free to add > my Tested-by. Scratch that. I've sent v2 with your SoB. PTAL, because your original code snippet didn't have a SoB. https://lore.kernel.org/netdev/20240411-igc_led_deadlock-v2-1-b758c0c88b2b@linutronix.de/ Thanks, Kurt --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJHBAEBCgAxFiEEvLm/ssjDfdPf21mSwZPR8qpGc4IFAmYdCTYTHGt1cnRAbGlu dXRyb25peC5kZQAKCRDBk9HyqkZzgsf3EACno5JgtsdefQPawYHdXfivHhXfpDK6 s7wTlGnEk1GOdVN5Z7RfiOu+82Fyyhw+fLoxCa9AsezeSHFWduGwJPR5BFG7FMP1 +mP4i5T/X1naOgi0RU/IO/Md2u9UO7CgeELbOTMwv3B9ETD6dyd7ZIDl/lSUzgr2 dzRud16ri0O7pQvmwOEdO8C6utcVbKYZ+umDcCvRBKSeVJ/HnuPXmexFFtBy7wlI gseiIM38HJfUVZ1O1glf9FG9kt8Z8YJ4ETmTyGiu2nmC/zp3Jcd7Lc1LkZ1oQhMp cfAKgBAZQQ7bUVAtaiAR+xe6dm1tgOVYgwtB3lZmJ9j0XTtPBkAIvqmR4bOKx5PL OrqgzWgdtkbLJWb89MOinnN/EOQL00BAVn/nhhqUTsaaETTzXrLmyqsxjpU8uvzA CoJzUsf5Yt4nZwHsVDFqTUNPF5mwkSF2+Vr3fLwdPzmb5ZxgpyEIPo6lAKcinyKR 8cxGW8Qy1ArGRuQR7y8MUOIYHFupXQDtJvhqFT28vEwm4fk8BfexWefgEdabO0FE PJyI2m2Y1gHzNn+fkmTCKxtBcZsixMgjRAomkcYtnYDUqJfO/boaVwAI0IiHTGK4 WbJ+T5slDNT5CZgT/jfuqrSWCB6+4id8qkUP/ObLDRcyx1vuTJH77Gumljd6tdxy ILHI2R31Mdz10g== =394O -----END PGP SIGNATURE----- --=-=-=-- From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A2C065FDDB for ; Mon, 15 Apr 2024 11:02:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713178939; cv=none; b=JR6Qep0gz3K57WhE8HtS1SCNJDzch8Nt41hVP0Zvlm8cDaV0il/LJ4pEVyD1j+rknQSdx7brozcdT3xqCFR1oUdSGbqNYiT13ykGmd+i6s2zIgIy18hB/4M4Wi/6TPn8wFx0YQrS4mVE6MP/vuTZ9TtAG7IqBM/TV6g0hlsczNM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713178939; c=relaxed/simple; bh=Iup/E2Z1WjEWPfxFDQcDvpZjGXHr6zId0gCi5u7ymqw=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=iuCgrwSa+saixwmP4hbKJDvRjjePSgiLEQGAj0S1sSi0GrT1OjNHNJBJjKGxiIghiW89bPezgYWI5zyW/xlF6fn+RHocbW5jCeMwV/sLdrcBW8S9Sb08jPI4mtoTwgXbZALpHjswwMx+nzx4CBEmOJwq5pCt2Z30iFLWAXpF7vQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=YeAUzIja; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=JTYhWBoS; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="YeAUzIja"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="JTYhWBoS" From: Kurt Kanzenbach DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1713178935; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Iup/E2Z1WjEWPfxFDQcDvpZjGXHr6zId0gCi5u7ymqw=; b=YeAUzIjafFVlWbU1pQ9y8y+2P+9UB8Is9zbnnVTOS+U7e9uww22L5/mDdCGNZBYZC/LZqg eb9zKRiAcJuSXfs7akEJRudSoFsUKbEQyn2T73zRTQJvQgON5B8m6Cs+foX+cIg9P13muZ aXyuH8Tg7VqumsZcj4sNJvtv7YMbIkx4pxxAyflu6BolIHAoXMcfx/cwoo4Yo3QzDK2qkW PfKN2Nx0KWkWO8W2FdTj69lq+gkRWOS3ysQC7GKUgIcyim5CnYVPcgJEY9uk+tL4agYeko 631VPRBf+6x8nBafPwK4sxnh4v5hhcyiSK4qDiZhhh23GbaWvEphnMThDHKmmw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1713178935; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Iup/E2Z1WjEWPfxFDQcDvpZjGXHr6zId0gCi5u7ymqw=; b=JTYhWBoSpOWfwwzFaW5Sl9JOi1z+jl3L4JWydwgAzR4GuFjZAzfxsWXaIQt4Bpiq5puYAF 7BGSjlR1WORM5ADA== To: Lukas Wunner , Roman Lozko Cc: Jesse Brandeburg , Tony Nguyen , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , Sasha Neftin , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org Subject: Re: [PATCH iwl-net] igc: Fix deadlock on module removal In-Reply-To: <877ch0b901.fsf@kurt.kurt.home> References: <20240411-igc_led_deadlock-v1-1-0da98a3c68c5@linutronix.de> <877ch0b901.fsf@kurt.kurt.home> Date: Mon, 15 Apr 2024 13:02:14 +0200 Message-ID: <87zftukhxl.fsf@kurt.kurt.home> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain Lukas, >> I would have been happy to submit a patch myself, I was waiting >> for a Tested-by from Roman or you. > > Perfect. I was wondering why you are not submitting the patch > yourself. Then, please go ahead and submit the patch. Feel free to add > my Tested-by. Scratch that. I've sent v2 with your SoB. PTAL, because your original code snippet didn't have a SoB. https://lore.kernel.org/netdev/20240411-igc_led_deadlock-v2-1-b758c0c88b2b@linutronix.de/ Thanks, Kurt --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJHBAEBCgAxFiEEvLm/ssjDfdPf21mSwZPR8qpGc4IFAmYdCTYTHGt1cnRAbGlu dXRyb25peC5kZQAKCRDBk9HyqkZzgsf3EACno5JgtsdefQPawYHdXfivHhXfpDK6 s7wTlGnEk1GOdVN5Z7RfiOu+82Fyyhw+fLoxCa9AsezeSHFWduGwJPR5BFG7FMP1 +mP4i5T/X1naOgi0RU/IO/Md2u9UO7CgeELbOTMwv3B9ETD6dyd7ZIDl/lSUzgr2 dzRud16ri0O7pQvmwOEdO8C6utcVbKYZ+umDcCvRBKSeVJ/HnuPXmexFFtBy7wlI gseiIM38HJfUVZ1O1glf9FG9kt8Z8YJ4ETmTyGiu2nmC/zp3Jcd7Lc1LkZ1oQhMp cfAKgBAZQQ7bUVAtaiAR+xe6dm1tgOVYgwtB3lZmJ9j0XTtPBkAIvqmR4bOKx5PL OrqgzWgdtkbLJWb89MOinnN/EOQL00BAVn/nhhqUTsaaETTzXrLmyqsxjpU8uvzA CoJzUsf5Yt4nZwHsVDFqTUNPF5mwkSF2+Vr3fLwdPzmb5ZxgpyEIPo6lAKcinyKR 8cxGW8Qy1ArGRuQR7y8MUOIYHFupXQDtJvhqFT28vEwm4fk8BfexWefgEdabO0FE PJyI2m2Y1gHzNn+fkmTCKxtBcZsixMgjRAomkcYtnYDUqJfO/boaVwAI0IiHTGK4 WbJ+T5slDNT5CZgT/jfuqrSWCB6+4id8qkUP/ObLDRcyx1vuTJH77Gumljd6tdxy ILHI2R31Mdz10g== =394O -----END PGP SIGNATURE----- --=-=-=--