From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D153DC54E67 for ; Wed, 20 Mar 2024 11:40:18 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 6CEC540802; Wed, 20 Mar 2024 11:40:18 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Ywd2ByqHSAcl; Wed, 20 Mar 2024 11:40:17 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 7D250407BD DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1710934817; bh=pwE/GBJYLkV/7/yUUomeUZHide/jRSkFJUzETBE/thU=; h=From:To:In-Reply-To:References:Date:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=A+mvl0DURhHkv/iq4R1/DRYH5UP7ZZ/8tKuPI7uVJdZ8j9y2Rj4D7p+GtM8RSrX/g /GSzirrphfXMOhlqJwXBMeXQjcZqEvV4z3GFevCjHO0b8bkyL8KNpd2jAh46UcJUxP hVrmHLFQc1MIeCvpTg+UyolVWO5APeT3TJeYBEgXMOTVPDRtznyzX4V4LJXDzEQs0C 6Gi/jB5auJUykzga4BtYwfhVmNq70olzMx84qY99SSeFb1zuzH+NdTQDOJiENgXvy0 BtWVFCzNl4xq6TKxxky8LBrzrNJsoE+rVxEfQten2mqLFYRgQspIJURotGRSQq74ND SjlcXHbr+ijYA== Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp4.osuosl.org (Postfix) with ESMTP id 7D250407BD; Wed, 20 Mar 2024 11:40:17 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 4A7281BF2F5 for ; Wed, 20 Mar 2024 11:40:15 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 35102407BD for ; Wed, 20 Mar 2024 11:40:15 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sZsDGimKnos7 for ; Wed, 20 Mar 2024 11:40:14 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2a0a:51c0:0:12e:550::1; helo=galois.linutronix.de; envelope-from=tglx@linutronix.de; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp4.osuosl.org 4BBAA406FC DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 4BBAA406FC Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by smtp4.osuosl.org (Postfix) with ESMTPS id 4BBAA406FC for ; Wed, 20 Mar 2024 11:40:14 +0000 (UTC) From: Thomas Gleixner To: lakshmi.sowjanya.d@intel.com, jstultz@google.com, giometti@enneenne.com, corbet@lwn.net, linux-kernel@vger.kernel.org In-Reply-To: <875xxhi1ty.ffs@tglx> References: <20240319130547.4195-1-lakshmi.sowjanya.d@intel.com> <20240319130547.4195-2-lakshmi.sowjanya.d@intel.com> <875xxhi1ty.ffs@tglx> Date: Wed, 20 Mar 2024 12:30:52 +0100 Message-ID: <87zfutgmxf.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1710934253; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pwE/GBJYLkV/7/yUUomeUZHide/jRSkFJUzETBE/thU=; b=MET3jxyqm1sXOQn5gphkidNCjfG+Tr/p2/ki9n+/AqGfDi6uzTb2aT/MyL+ioOWks6ndHO MI95oCOA1zQP2cwvzPcoi7DRiq7z2zXhoQrgJCUxMxEHjz9x4uvFfD/XYPX3zBQTUr65XL lNTFECeMgVwWMspuPc3Omri78q9n2MBo8amNB3KLmOlgidIbjna0YRPG5+YXucDf8l0X6t Xe5iJoS5QZsKia9g+j3+SDVmp31i41KL3GoBs5cawaUNf+yvjjaPvcxueJEeMTUBz6dcYS q1ELLfg0R+vKzoni0nnLM5iim2DRcVOb6v7gUhRjGS7rNFMU1AXrXD/j6iMeew== X-Mailman-Original-DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1710934253; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pwE/GBJYLkV/7/yUUomeUZHide/jRSkFJUzETBE/thU=; b=KD+F/3vIh9T1cQ/PXywhSvE5rgPwIOfCSkG52QZ7ALq7BZCiJ1z2qhgQYCog3Dp3vC7iyf WkvevLWZUyLc3cCw== X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dmarc=pass (p=none dis=none) header.from=linutronix.de X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=linutronix.de header.i=@linutronix.de header.a=rsa-sha256 header.s=2020 header.b=MET3jxyq; dkim=pass header.d=linutronix.de header.i=@linutronix.de header.a=ed25519-sha256 header.s=2020e header.b=KD+F/3vI Subject: Re: [Intel-wired-lan] [PATCH v5 01/11] x86/tsc: Add base clock properties in clocksource structure X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-doc@vger.kernel.org, mallikarjunappa.sangannavar@intel.com, alexandre.torgue@foss.st.com, perex@perex.cz, basavaraj.goudar@intel.com, thejesh.reddy.t.r@intel.com, christopher.s.hall@intel.com, x86@kernel.org, joabreu@synopsys.com, peter.hilber@opensynergy.com, intel-wired-lan@lists.osuosl.org, subramanian.mohan@intel.com, linux-sound@vger.kernel.org, lakshmi.sowjanya.d@intel.com, andriy.shevchenko@linux.intel.com, netdev@vger.kernel.org, pandith.n@intel.com, eddie.dong@intel.com, mcoquelin.stm32@gmail.com, anthony.l.nguyen@intel.com, davem@davemloft.net Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Wed, Mar 20 2024 at 12:23, Thomas Gleixner wrote: > On Tue, Mar 19 2024 at 18:35, lakshmi.sowjanya.d@intel.com wrote: >> From: Lakshmi Sowjanya D >> >> Add base clock hardware abstraction in clocksource structure. >> >> Add clocksource ID for x86 ART(Always Running Timer). > > This change log tells the WHAT but not the WHY. You have to add context > and explanation WHY this change is required and why it makes sense. > > Also I think this should be ordered differently: > > 1) Add the clocksource_base struct and provide the infrastructure in > get_device_system_crosststamp() > > 2) Make TSC/ART use it 2a) Remove the art to tsc conversion in drivers 2b) Remove art to tsc > 3) Add the realtime muck > > Thanks, > > tglx From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A2A7A3BBC8; Wed, 20 Mar 2024 11:30:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710934256; cv=none; b=dZtF/N88IPJDVE/cwljpyuWXFhn9maDRfKXwdLcZbFXMugA8RNkrv3GjLGLoIxHVfCIjAD4VCf1EerZ0dI2pN2Y3UDSfqKvluooT+x+hMu0xrcrG8dfhVYEglXzAqBG5GvJu+jaUM45GzXoFvM37Uozs2wdrUgl1hTQ2YIZ+PKU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710934256; c=relaxed/simple; bh=a8TOprEuyws5CRENEXE+KPayvt7+FUvQnptRl61id2g=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=VjzTdcXQDUf/yZItJ/KhFghpbxqzXP2DVzahW+5TDyS+cRg62pJJ3DtZxH+Tf8srnVKGqPb7M29i7PK2fLcuTqju5I1Sq0FQPJQAqTBLK1cYatoTn9ThlR2m6FKVfLMAD7pPKnL7yT3ChavhYBTgYR6tm3wX75UH8BkgGnErVy8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=MET3jxyq; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=KD+F/3vI; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="MET3jxyq"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="KD+F/3vI" From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1710934253; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pwE/GBJYLkV/7/yUUomeUZHide/jRSkFJUzETBE/thU=; b=MET3jxyqm1sXOQn5gphkidNCjfG+Tr/p2/ki9n+/AqGfDi6uzTb2aT/MyL+ioOWks6ndHO MI95oCOA1zQP2cwvzPcoi7DRiq7z2zXhoQrgJCUxMxEHjz9x4uvFfD/XYPX3zBQTUr65XL lNTFECeMgVwWMspuPc3Omri78q9n2MBo8amNB3KLmOlgidIbjna0YRPG5+YXucDf8l0X6t Xe5iJoS5QZsKia9g+j3+SDVmp31i41KL3GoBs5cawaUNf+yvjjaPvcxueJEeMTUBz6dcYS q1ELLfg0R+vKzoni0nnLM5iim2DRcVOb6v7gUhRjGS7rNFMU1AXrXD/j6iMeew== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1710934253; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pwE/GBJYLkV/7/yUUomeUZHide/jRSkFJUzETBE/thU=; b=KD+F/3vIh9T1cQ/PXywhSvE5rgPwIOfCSkG52QZ7ALq7BZCiJ1z2qhgQYCog3Dp3vC7iyf WkvevLWZUyLc3cCw== To: lakshmi.sowjanya.d@intel.com, jstultz@google.com, giometti@enneenne.com, corbet@lwn.net, linux-kernel@vger.kernel.org Cc: x86@kernel.org, netdev@vger.kernel.org, linux-doc@vger.kernel.org, intel-wired-lan@lists.osuosl.org, andriy.shevchenko@linux.intel.com, eddie.dong@intel.com, christopher.s.hall@intel.com, jesse.brandeburg@intel.com, davem@davemloft.net, alexandre.torgue@foss.st.com, joabreu@synopsys.com, mcoquelin.stm32@gmail.com, perex@perex.cz, linux-sound@vger.kernel.org, anthony.l.nguyen@intel.com, peter.hilber@opensynergy.com, pandith.n@intel.com, mallikarjunappa.sangannavar@intel.com, subramanian.mohan@intel.com, basavaraj.goudar@intel.com, thejesh.reddy.t.r@intel.com, lakshmi.sowjanya.d@intel.com Subject: Re: [PATCH v5 01/11] x86/tsc: Add base clock properties in clocksource structure In-Reply-To: <875xxhi1ty.ffs@tglx> References: <20240319130547.4195-1-lakshmi.sowjanya.d@intel.com> <20240319130547.4195-2-lakshmi.sowjanya.d@intel.com> <875xxhi1ty.ffs@tglx> Date: Wed, 20 Mar 2024 12:30:52 +0100 Message-ID: <87zfutgmxf.ffs@tglx> Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Wed, Mar 20 2024 at 12:23, Thomas Gleixner wrote: > On Tue, Mar 19 2024 at 18:35, lakshmi.sowjanya.d@intel.com wrote: >> From: Lakshmi Sowjanya D >> >> Add base clock hardware abstraction in clocksource structure. >> >> Add clocksource ID for x86 ART(Always Running Timer). > > This change log tells the WHAT but not the WHY. You have to add context > and explanation WHY this change is required and why it makes sense. > > Also I think this should be ordered differently: > > 1) Add the clocksource_base struct and provide the infrastructure in > get_device_system_crosststamp() > > 2) Make TSC/ART use it 2a) Remove the art to tsc conversion in drivers 2b) Remove art to tsc > 3) Add the realtime muck > > Thanks, > > tglx