From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C25BEC54E58 for ; Mon, 11 Mar 2024 18:17:00 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rjkCT-0004ff-7M; Mon, 11 Mar 2024 14:16:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rjkCR-0004Yz-8f for qemu-devel@nongnu.org; Mon, 11 Mar 2024 14:16:35 -0400 Received: from smtp-out1.suse.de ([195.135.223.130]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rjkCP-0006ca-Ie for qemu-devel@nongnu.org; Mon, 11 Mar 2024 14:16:35 -0400 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 4DF472293A; Mon, 11 Mar 2024 18:16:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1710180990; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gd6Bvc/blDoQ1glmHothwhFFY92Sv+zQx1P3mT+72wA=; b=BNVQBG+2yvNL1h+SPHM/B8pFafRhrRseJyK23jyu1HNcTYRWF7nuEcVjOLdPE4OOOTYe88 VaoIwMvsH1SVFbH4NQIdXvIteZXj+hpwIVWbvidxN2OXijUDt8X3CjPW44KP6NtLypTkQc Ke8h5SnAzQ2l+GvOmCy+IsX/Rf1GsB4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1710180990; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gd6Bvc/blDoQ1glmHothwhFFY92Sv+zQx1P3mT+72wA=; b=WfIUO+uIcERLIcQhKcdFVwlI9wzyDGiX7r8TsKel37g0LA6h65/a5ZkNFajYHCDlzZIPND qgTPyNZB97y7p+BQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1710180989; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gd6Bvc/blDoQ1glmHothwhFFY92Sv+zQx1P3mT+72wA=; b=WIXbTYVXngn5qR1hCkV8oegkn/ZDKvs68WJK7TRODtN4Dy+OD5RU2MeMJWPvbnfBukxMq2 VyOl9tB0jFGnirzoFUEZaFEBhHwL/cSmbcDdfWEbTxgidWX21Urld8VYwM/oJ5I2GH629y R8dAFeb7Itp0RVtbej0jVooOO0eLFHY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1710180989; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gd6Bvc/blDoQ1glmHothwhFFY92Sv+zQx1P3mT+72wA=; b=zsC3h0Djz4Osm5BzlwjpIKJeHKo5RrkwRM6aVvG5yTq/Pcw9g3g/63dZClMwnkr7thPmKH aCgCMh6S9xJ6u1CQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id C8389136BA; Mon, 11 Mar 2024 18:16:28 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id m6xSI3xK72XhOAAAD6G6ig (envelope-from ); Mon, 11 Mar 2024 18:16:28 +0000 From: Fabiano Rosas To: Het Gala , qemu-devel@nongnu.org Cc: marcandre.lureau@redhat.com, thuth@redhat.com, lvivier@redhat.com, pbonzini@redhat.com, Het Gala Subject: Re: [PATCH v4 2/8] Replace connect_uri and move migrate_get_socket_address inside migrate_qmp In-Reply-To: <20240308205951.111747-3-het.gala@nutanix.com> References: <20240308205951.111747-1-het.gala@nutanix.com> <20240308205951.111747-3-het.gala@nutanix.com> Date: Mon, 11 Mar 2024 15:16:26 -0300 Message-ID: <87zfv4my6d.fsf@suse.de> MIME-Version: 1.0 Content-Type: text/plain Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=WIXbTYVX; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=zsC3h0Dj X-Spamd-Result: default: False [-5.81 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; BAYES_HAM(-3.00)[99.99%]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; MIME_GOOD(-0.10)[text/plain]; RCVD_DKIM_ARC_DNSWL_HI(-1.00)[]; DWL_DNSWL_LOW(-1.00)[suse.de:dkim]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+]; MX_GOOD(-0.01)[]; RCPT_COUNT_SEVEN(0.00)[7]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email,suse.de:dkim]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_IN_DNSWL_HI(-0.50)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from] X-Rspamd-Queue-Id: 4DF472293A X-Rspamd-Server: rspamd1.dmz-prg2.suse.org Received-SPF: pass client-ip=195.135.223.130; envelope-from=farosas@suse.de; helo=smtp-out1.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Het Gala writes: > Move the calls to migrate_get_socket_address() into migrate_qmp(). > Get rid of connect_uri and replace it with args->connect_uri only > because 'to' object will help to generate connect_uri with the > correct port number. > > Signed-off-by: Het Gala > Suggested-by: Fabiano Rosas > Reviewed-by: Fabiano Rosas > --- > tests/qtest/migration-helpers.c | 55 ++++++++++++++++++++++- > tests/qtest/migration-test.c | 79 +++++---------------------------- > 2 files changed, 64 insertions(+), 70 deletions(-) > > diff --git a/tests/qtest/migration-helpers.c b/tests/qtest/migration-helpers.c > index b6206a04fb..9af3c7d4d5 100644 > --- a/tests/qtest/migration-helpers.c > +++ b/tests/qtest/migration-helpers.c > @@ -13,6 +13,10 @@ > #include "qemu/osdep.h" > #include "qemu/ctype.h" > #include "qapi/qmp/qjson.h" > +#include "qemu/sockets.h" > +#include "qapi/qapi-visit-sockets.h" > +#include "qapi/qobject-input-visitor.h" > +#include "qapi/error.h" Are any of these now superfluous at migration-test.c?