All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Paolo Bonzini <pbonzini@redhat.com>,
	linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Cc: x86@kernel.org, Stephen Rothwell <sfr@canb.auug.org.au>,
	Xin Li <xin@zytor.com>
Subject: Re: [PATCH] x86: irq: unconditionally define KVM interrupt vectors
Date: Mon, 26 Feb 2024 16:10:05 +0100	[thread overview]
Message-ID: <87zfvn9s8i.ffs@tglx> (raw)
In-Reply-To: <20240223102229.627664-1-pbonzini@redhat.com>

On Fri, Feb 23 2024 at 05:22, Paolo Bonzini wrote:
> Unlike arch/x86/kernel/idt.c, FRED support chose to remove the #ifdefs
> from the .c files and concentrate them in the headers, where unused
> handlers are #define'd to NULL.
>
> However, the constants for KVM's 3 posted interrupt vectors are still
> defined conditionally in irq_vectors.h.  In the tree that FRED support was
> developed on, this is innocuous because CONFIG_HAVE_KVM was effectively
> always set.  With the cleanups that recently went into the KVM tree to
> remove CONFIG_HAVE_KVM, the conditional became IS_ENABLED(CONFIG_KVM).
> This causes a linux-next compilation failure in FRED code, when
> CONFIG_KVM=n.
>
> In preparation for the merging of FRED in Linux 6.9, define the interrupt
> vector numbers unconditionally.
>
> Cc: x86@kernel.org
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Suggested-by: Xin Li (Intel) <xin@zytor.com>
> Suggested-by: Thomas Gleixner <tglx@linutronix.de>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Reviewed-by: Thomas Gleixner <tglx@linutronix.de>

      parent reply	other threads:[~2024-02-26 15:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-23 10:22 [PATCH] x86: irq: unconditionally define KVM interrupt vectors Paolo Bonzini
2024-02-23 18:49 ` Xin Li
2024-02-26 15:10 ` Thomas Gleixner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zfvn9s8i.ffs@tglx \
    --to=tglx@linutronix.de \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=sfr@canb.auug.org.au \
    --cc=x86@kernel.org \
    --cc=xin@zytor.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.