From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 99660C48BC4 for ; Tue, 20 Feb 2024 06:31:53 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rcJf0-0004Lj-AF; Tue, 20 Feb 2024 01:31:22 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rcJey-0004LW-Kf for qemu-devel@nongnu.org; Tue, 20 Feb 2024 01:31:20 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rcJex-0001zd-9E for qemu-devel@nongnu.org; Tue, 20 Feb 2024 01:31:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1708410677; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-to: resent-from:resent-message-id:in-reply-to:in-reply-to: references:references; bh=P+PT/rgoYlq8/aIpySpstQu2/twqT94Q/QZI89qK8jk=; b=FZjJR8+/FVeXupfOT46tz5IN8HJ0r/AFDF3N0FoVHLVwUO3Ter3gRY46BUYZSkr5DNKv+n 5e6/1Q6AaFuxkJ7hDIYJEqZwrlrwHgwOqGPaYHeiEe8I9iEBv0cujCyr4zB05nM7/AIqHF BQOE3DfN1CcLbOhbTDTnXTP06tdPmDA= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-335-EnhaFWb5OXqr68mJG6zofw-1; Tue, 20 Feb 2024 01:31:14 -0500 X-MC-Unique: EnhaFWb5OXqr68mJG6zofw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 25FFA85A59C; Tue, 20 Feb 2024 06:31:14 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.192.55]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4E5901121306; Tue, 20 Feb 2024 06:31:01 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 2257F21E66C8; Tue, 20 Feb 2024 07:31:13 +0100 (CET) Resent-To: yong.huang@smartx.com, qemu-devel@nongnu.org Resent-From: Markus Armbruster Resent-Date: Tue, 20 Feb 2024 07:31:13 +0100 Resent-Message-ID: <87sf1nejf2.fsf@pond.sub.org> From: Markus Armbruster To: yong.huang@smartx.com Cc: qemu-devel@nongnu.org, Daniel P . =?utf-8?Q?Berrang=C3=A9?= , Eric Blake , Hanna Reitz , Kevin Wolf Subject: Re: [PATCH v4 2/7] qapi: Make parameter 'file' optional for BlockdevCreateOptionsLUKS In-Reply-To: (yong huang's message of "Tue, 30 Jan 2024 13:37:20 +0800") References: Date: Mon, 19 Feb 2024 15:22:14 +0100 Message-ID: <87zfvwjzzd.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.3 Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.072, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org yong.huang@smartx.com writes: > From: Hyman Huang > > To support detached LUKS header creation, make the existing 'file' > field in BlockdevCreateOptionsLUKS optional. > > Signed-off-by: Hyman Huang > Reviewed-by: Daniel P. Berrang=C3=A9 [...] > diff --git a/qapi/block-core.json b/qapi/block-core.json > index ae604c6019..69a88d613d 100644 > --- a/qapi/block-core.json > +++ b/qapi/block-core.json > @@ -4957,7 +4957,8 @@ > # > # Driver specific image creation options for LUKS. > # > -# @file: Node to create the image format on > +# @file: Node to create the image format on, mandatory except when > +# 'preallocation' is not requested You mean when @preallocation is "off"? Cases: 1. @file is mandatory 2. @file is optional and present 3. @file is optional and absent Ignorant question: behavior in each case? > # > # @size: Size of the virtual disk in bytes > # > @@ -4968,7 +4969,7 @@ > ## > { 'struct': 'BlockdevCreateOptionsLUKS', > 'base': 'QCryptoBlockCreateOptionsLUKS', > - 'data': { 'file': 'BlockdevRef', > + 'data': { '*file': 'BlockdevRef', > 'size': 'size', > '*preallocation': 'PreallocMode' } }