From: Michael Ellerman <mpe@ellerman.id.au>
To: David Heidelberg <david@ixit.cz>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Nicholas Piggin <npiggin@gmail.com>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Jakub Kicinski <kuba@kernel.org>,
Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH] powerpc/fsl: fix the schema check errors for fsl,tmu-calibration
Date: Tue, 19 Dec 2023 17:36:11 +1100 [thread overview]
Message-ID: <87zfy6lmw4.fsf@mail.lhotse> (raw)
In-Reply-To: <7259e7fe-157e-4cc7-9e82-98cb8e32bfed@ixit.cz>
David Heidelberg <david@ixit.cz> writes:
> On 13/12/2023 06:17, Michael Ellerman wrote:
>> David Heidelberg <david@ixit.cz> writes:
>>> fsl,tmu-calibration is in u32-matrix. Use matching property syntax.
>>> No functional changes. Fixes warnings as:
>>> $ make dtbs_check
>>> ...
>>> arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dt.yaml: tmu@30260000: fsl,tmu-calibration:0: Additional items are not allowed (1, 41, 2, 47, 3, 53, 4, 61, 5, 67, 6, 75, 7, 81, 8, 87, 9, 95, 10, 103, 11, 111
>> This file name doesn't match the one you're modifying?
> Hello Michael. I mentioned this as a example of same problem (I
> originally sent more patches to fix it across DTS files)
>>
>>> , 65536, 27, 65537, 35, 65538, 43, 65539, 51, 65540, 59, 65541, 67, 65542, 75, 65543, 85, 65544, 93, 65545, 103, 65546, 112, 131072, 23, 131073, 35, 131074, 45, 131075, 55, 131076, 65, 131077, 75, 131078, 87, 13
>>> 1079, 99, 131080, 111, 196608, 21, 196609, 33, 196610, 45, 196611, 57, 196612, 69, 196613, 83, 196614, 95, 196615, 113 were unexpected)
>>> From schema: Documentation/devicetree/bindings/thermal/qoriq-thermal.yaml
>>> ...
>> I don't see any errors like this. I guess I'm running the tests wrong?
>
> Currently I see also no error :(
At least it's not just me :)
> If you look into
> Documentation/devicetree/bindings/thermal/qoriq-thermal.yaml you can see
> that
>
> `fsl,tmu-calibration` matches the change I'm introducing here, most
> likely there is a bug in validator or syntax is not 100% correct.
OK. I'll merge the patch as "correct per documentation" and just edit
the commit message to drop the error message so as not to confuse anyone.
cheers
next prev parent reply other threads:[~2023-12-19 6:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-12 18:44 [RESEND PATCH] powerpc/fsl: fix the schema check errors for fsl,tmu-calibration David Heidelberg
2023-12-13 5:17 ` Michael Ellerman
2023-12-14 12:30 ` David Heidelberg
2023-12-19 6:36 ` Michael Ellerman [this message]
2023-12-21 10:38 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zfy6lmw4.fsf@mail.lhotse \
--to=mpe@ellerman.id.au \
--cc=christophe.leroy@csgroup.eu \
--cc=conor+dt@kernel.org \
--cc=david@ixit.cz \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=npiggin@gmail.com \
--cc=robh+dt@kernel.org \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.