From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 237E4C10DC1 for ; Thu, 30 Nov 2023 10:13:26 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r8e2A-00083C-Sj; Thu, 30 Nov 2023 05:12:38 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r8e28-0007yf-2a for qemu-devel@nongnu.org; Thu, 30 Nov 2023 05:12:36 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r8e26-0000uv-Kc for qemu-devel@nongnu.org; Thu, 30 Nov 2023 05:12:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701339153; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Pa4PeLRwkHQDiuV8SpMxPnM0xTJf4fAE4DmF3QImiWw=; b=cylAOH0ER3HRgFzFpGVLOOrpF26dJwW/GozLc2Z0Et4AooCqe/fVTjuKkMQDBbWOtJ/VtZ n7JszvYYCePWWxgVOM+FDEeEZ6zEGctBLLH/2IaHfHPcnv1V6K51QgjAbqKBu1P/DiVMCq Qx3cHr0t7oVxYqQJx8PvNt3Rpmd31q4= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-561-zS0GR0C1MbmF6XErjji_uA-1; Thu, 30 Nov 2023 05:12:30 -0500 X-MC-Unique: zS0GR0C1MbmF6XErjji_uA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4FA5328088A2; Thu, 30 Nov 2023 10:12:30 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.192.148]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2AF3C10E46; Thu, 30 Nov 2023 10:12:30 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 2E3B421E6A1F; Thu, 30 Nov 2023 11:12:29 +0100 (CET) From: Markus Armbruster To: Sam Li Cc: qemu-devel@nongnu.org, stefanha@redhat.com, Klaus Jensen , qemu-block@nongnu.org, hare@suse.de, David Hildenbrand , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Keith Busch , Hanna Reitz , dmitry.fomichev@wdc.com, Kevin Wolf , Eric Blake , Peter Xu , Paolo Bonzini , dlemoal@kernel.org Subject: Re: [RFC v2 2/7] qcow2: add zd_extension configurations to zoned metadata References: <20231127085641.3729-1-faithilikerun@gmail.com> <20231127085641.3729-3-faithilikerun@gmail.com> Date: Thu, 30 Nov 2023 11:12:29 +0100 In-Reply-To: <20231127085641.3729-3-faithilikerun@gmail.com> (Sam Li's message of "Mon, 27 Nov 2023 16:56:36 +0800") Message-ID: <87zfyvblde.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.5 Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sam Li writes: > Zone descriptor data is host definied data that is associated with > each zone. Add zone descriptor extensions to zonedmeta struct. > > Signed-off-by: Sam Li [...] > struct BlockBackendRootState { > diff --git a/qapi/block-core.json b/qapi/block-core.json > index ef98dc83a0..a7f238371c 100644 > --- a/qapi/block-core.json > +++ b/qapi/block-core.json > @@ -5074,12 +5074,16 @@ > # append request that can be issued to the device. It must be > # 512-byte aligned > # > +# @descriptor-extension-size: The size of zone descriptor extension > +# data. Must be a multiple of 64 bytes (since 8.2) Two spaces between sentences for consistency, please. What's the default? > +# > # Since 8.2 > ## > { 'struct': 'Qcow2ZoneHostManaged', > 'data': { '*size': 'size', > '*capacity': 'size', > '*conventional-zones': 'uint32', > + '*descriptor-extension-size': 'size', > '*max-open-zones': 'uint32', > '*max-active-zones': 'uint32', > '*max-append-bytes': 'uint32' } }