From: Markus Armbruster <armbru@redhat.com>
To: Song Gao <gaosong@loongson.cn>
Cc: qemu-devel@nongnu.org, richard.henderson@linaro.org,
philmd@redhat.com, peter.maydell@linaro.org, eblake@redhat.com,
maobibo@loongson.cn
Subject: Re: [PATCH v1 3/3] target/loongarch: Implement query-cpu-model-expansion
Date: Wed, 18 Oct 2023 12:47:26 +0200 [thread overview]
Message-ID: <87zg0gryv5.fsf@pond.sub.org> (raw)
In-Reply-To: <20231018085908.3327130-4-gaosong@loongson.cn> (Song Gao's message of "Wed, 18 Oct 2023 16:59:08 +0800")
Song Gao <gaosong@loongson.cn> writes:
> Add support for the query-cpu-model-expansion QMP command to LoongArch.
> We only support query the 'max' cpu features.
>
> e.g
> start with '-cpu max,lasx=off'
>
> (QEMU) query-cpu-model-expansion type=static model={"name":"max"}
> {"return": {"model": {"name": "max", "props": {"lasx": false, "lsx": true}}}}
Suggest to show what happens when you try to query something else.
> Signed-off-by: Song Gao <gaosong@loongson.cn>
> ---
> qapi/machine-target.json | 6 ++-
> target/loongarch/loongarch-qmp-cmds.c | 64 +++++++++++++++++++++++++++
> 2 files changed, 68 insertions(+), 2 deletions(-)
>
> diff --git a/qapi/machine-target.json b/qapi/machine-target.json
> index f0a6b72414..752b18cced 100644
> --- a/qapi/machine-target.json
> +++ b/qapi/machine-target.json
> @@ -228,7 +228,8 @@
> 'data': { 'model': 'CpuModelInfo' },
> 'if': { 'any': [ 'TARGET_S390X',
> 'TARGET_I386',
> - 'TARGET_ARM' ] } }
> + 'TARGET_ARM',
> + 'TARGET_LOONGARCH64' ] } }
>
> ##
> # @query-cpu-model-expansion:
> @@ -273,7 +274,8 @@
> 'returns': 'CpuModelExpansionInfo',
> 'if': { 'any': [ 'TARGET_S390X',
> 'TARGET_I386',
> - 'TARGET_ARM' ] } }
> + 'TARGET_ARM',
> + 'TARGET_LOONGARCH64' ] } }
>
> ##
> # @CpuDefinitionInfo:
QAPI schema
Acked-by: Markus Armbruster <armbru@redhat.com>
[...]
prev parent reply other threads:[~2023-10-18 10:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-18 8:59 [PATCH v1 0/3] Allow user enable/disable LSX/LASX features Song Gao
2023-10-18 8:59 ` [PATCH v1 1/3] target/loongarch: Add cpu model 'max' Song Gao
2023-10-18 8:59 ` [PATCH v1 2/3] target/loongarch: Allow user enable/disable LSX/LASX features Song Gao
2023-10-18 23:47 ` Richard Henderson
2023-10-19 3:27 ` gaosong
2023-10-18 8:59 ` [PATCH v1 3/3] target/loongarch: Implement query-cpu-model-expansion Song Gao
2023-10-18 10:47 ` Markus Armbruster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zg0gryv5.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=gaosong@loongson.cn \
--cc=maobibo@loongson.cn \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.